Avoid shadowing builtins (#303)

Author: nathanjmcdougall

pins/boards.py

@@ -228,15 +228,16 @@ def _pin_store(
         *,
         force_identical_write: bool = False,
     ) -> Meta:
-        if type == "feather":
+        _type = type
+        if _type == "feather":
             warn_deprecated(
                 'Writing pin type "feather" is unsupported. Switching type to "arrow".'
                 " This produces the exact same behavior, and also works with R pins."
                 ' Please switch to pin_write using type="arrow".'
             )
-            type = "arrow"
+            _type = "arrow"
 
-        if type == "file":
+        if _type == "file":
             # the file type makes the name of the data the exact filename, rather
             # than the pin name + a suffix (e.g. my_pin.csv).
             if isinstance(x, (tuple, list)) and len(x) == 1:
@@ -264,7 +265,7 @@ def _pin_store(
                 tmp_dir,
                 x,
                 pin_name,
-                type,
+                _type,
                 title,
                 description,
                 metadata,

pins/cache.py

@@ -68,8 +68,8 @@ def __call__(self, path: str) -> str:
         if self.hash_prefix is not None:
             # optionally make the name relative to a parent path
             # using the hash of parent path as a prefix, to flatten a bit
-            hash = Path(path).relative_to(Path(self.hash_prefix))
-            return hash
+            _hash = Path(path).relative_to(Path(self.hash_prefix))
+            return _hash
 
         else:
             raise NotImplementedError()
@@ -102,8 +102,8 @@ def __call__(self, path):
         # the main change in this function is that, for same_name, it returns
         # the full path
         # change pin path of form <user>/<content> to <user>+<content>
-        hash = path.replace("/", "+", 1)
-        return hash
+        _hash = path.replace("/", "+", 1)
+        return _hash
 
 
 class PinsCache(SimpleCacheFileSystem):

pins/utils.py

@@ -22,10 +22,10 @@ def warn_deprecated(msg):
 
 def hash_name(path, same_name):
     if same_name:
-        hash = os.path.basename(path)
+        _hash = os.path.basename(path)
     else:
-        hash = hashlib.sha256(path.encode()).hexdigest()
-    return hash
+        _hash = hashlib.sha256(path.encode()).hexdigest()
+    return _hash
 
 
 class ExtendMethodDoc:

pyproject.toml

@@ -124,7 +124,9 @@ select = [
     "I",  # Import sorting
     "UP", # Upgrade to latest supported Python syntax
     "W",  # Style
+    "A",  # Don't shadow built-ins
 ]
 ignore = [
     "E501", # Line too long
+    "A002", # The pins interface includes builtin names in args, e.g. hash, id, etc.
 ]