-
Couldn't load subscription status.
- Fork 12
Description
At the moment, rdata is similar to pyarrow, etc. in the sense that it is optional, but still needed for testing and so I think it should be explicitly declared as a optional test dependency in setup.cfg.
This will mean it can be added as a pinned version to requirements/dev.txt rather than installed separately. This ensures consistency between local dev and CI and also ensures there is a consistent dependency resolution with dev.txt together with the rdata package.
I would like to do this, then the separate install step could be removed:
pins-python/.github/workflows/ci.yml
Lines 90 to 95 in 70380b4
| - name: Install dependencies | |
| run: | | |
| python -m pip install --upgrade pip | |
| python -m pip install -r requirements/dev.txt | |
| python -m pip install rdata | |
| python -m pip install -e .[test] |
Incidentally, I am not sure why python -m pip install -e .[test] is necessary since the test extra is already included in the dev.txt file. I think this could be removed too.