Fix linter warnings

Author: CDRayn

pkg/rsstorage/internal/integration_test/chunks_test.go

@@ -393,7 +393,6 @@ func (s *ChunksPartialReadSuite) TestReadPartialTimeout(c *check.C) {
 		for {
 			_, err := io.CopyN(pW, b, int64(cw.ChunkSize))
 			if err == io.EOF {
-				err = nil
 				return
 			}
 			c.Assert(err, check.IsNil)

pkg/rsstorage/internal/integration_test/integration.go

@@ -46,7 +46,7 @@ func getStorageServerAttempt(
 		if cfg.File == nil {
 			return nil, fmt.Errorf("Missing [FileStorage \"%s\"] configuration section", class)
 		}
-		//todo bioc: configurable size here
+		// todo bioc: configurable size here
 		server = file.NewStorageServer(
 			file.StorageServerArgs{
 				Dir:          cfg.File.Location,

pkg/rsstorage/internal/integration_test/integration_test.go

@@ -538,14 +538,16 @@ func (s *S3IntegrationSuite) SetUpSuite(c *check.C) {
 }
 
 var minioEndpoint = "http://minio:9000"
-var awsEndpoint = ""
+
+// Use this variable for customizing the AWS endpoint for debugging
+// var awsEndpoint = ""
 
 func (s *S3IntegrationSuite) TestPopulateServerSetHang(c *check.C) {
 	ctx := context.Background()
 	defer leaktest.Check(c)
 
 	// Customize these as needed for your environment
-	//endpoint := awsEndpoint // AWS
+	// endpoint := awsEndpoint // AWS
 	endpoint := minioEndpoint // MinIO
 	bucket := "rsstorage-minio-test"
 	region := "us-east-1"
@@ -613,7 +615,7 @@ func (s *S3IntegrationSuite) TestPopulateServerSetHang(c *check.C) {
 	resolver := func(class string) types.Resolver {
 		return func(w io.Writer) (string, string, error) {
 			// Start writing some data to the resolver's writer
-			//w.Write([]byte(fmt.Sprintf(testAssetData, class)))
+			// w.Write([]byte(fmt.Sprintf(testAssetData, class)))
 			gzw := gzip.NewWriter(w)
 
 			slog.Info("resolver: wrote some data, instructing test to continue, but waiting for instruction to err")

pkg/rsstorage/servers/s3server/server.go

@@ -26,7 +26,6 @@ import (
 const AmzUnencryptedContentLengthHeader = "X-Amz-Unencrypted-Content-Length"
 
 type moveOrCopyFn func(ctx context.Context, oldBucket, oldKey, newBucket, newKey string) (*s3.CopyObjectOutput, error)
-type copyFn func(ctx context.Context, input *s3.CopyObjectInput) (*s3.CopyObjectOutput, error)
 
 type StorageServer struct {
 	bucket  string
@@ -423,7 +422,7 @@ func (s *StorageServer) parts(ctx context.Context, dir, address string) ([]rssto
 		}
 		chunkDir := filepath.Join(dir, address)
 		parts = append(parts, rsstorage.NewCopyPart(chunkDir, "info.json"))
-		for i := 1; i <= int(chunked.NumChunks); i++ {
+		for i := uint64(1); i <= chunked.NumChunks; i++ {
 			chunkName := fmt.Sprintf("%08d", i)
 			parts = append(parts, rsstorage.NewCopyPart(chunkDir, chunkName))
 		}