Correctly render script tags defined as list() objects (#3395)

* Close #3345: correctly render script tags defined as list() objects

* implement boolean attrs; use vanilla JS

* Update news

* avoid toggleAttribute

* yarn lint (GitHub Actions)

* code review

Co-authored-by: cpsievert <[email protected]>

Author: cpsievert

NEWS.md

@@ -32,6 +32,8 @@ shiny 1.6.0.9000
 
 ### Bug fixes
 
+* Closed #3345: Shiny now correctly renders `htmltools::htmlDependency()`(s) with a `list()` of `script` attributes when used in a dynamic UI context. This fairly new `htmlDependency()` feature was added in `{htmltools}` v0.5.1. (#3395)
+
 * Closed #3374: `quoToFunction()` now works correctly with nested quosures; and as a result, quasi-quotation with rendering function (e.g., `renderPrint()`, `renderPlot()`, etc) now works as expected with nested quosures. (#3373) 
 
 * Exported `register_devmode_option()`. This method was described in the documentation for `devmode()` but was never exported. See `?devmode()` for more details on how to register Shiny Developer options using `register_devmode_option()`. (#3364)

inst/www/shared/shiny.js

@@ -4155,8 +4155,24 @@ function main(): void {
     }
 
     if (dep.script && !restyle) {
-      const scripts = $.map(asArray(dep.script), function (scriptName) {
-        return $("<script>").attr("src", href + "/" + encodeURI(scriptName));
+      const scripts_attrs = asArray(dep.script);
+      const scripts = $.map(scripts_attrs, function (x) {
+        let script = document.createElement("script");
+
+        // htmlDependency()'s script arg can be a character vector or a list()
+        if (typeof x === "string") {
+          x = { src: x };
+        }
+
+        for (let [attr, val] of Object.entries(x)) {
+          if (attr === "src") {
+            val = href + "/" + encodeURI(val);
+          }
+          // If val isn't truthy (e.g., null), consider it a boolean attribute
+          script.setAttribute(attr, val ? val : "");
+        }
+
+        return script;
       });
 
       $head.append(scripts);