Lint updates

Author: schloerke

srcts/src/bindings/input/actionbutton.ts

@@ -20,7 +20,7 @@ class ActionButtonInputBinding extends InputBinding {
   }
   getType(el: HTMLElement): string {
     return "shiny.action";
-    el;
+    el; // eslint-disable-line @typescript-eslint/no-unused-expressions
   }
   subscribe(el: HTMLElement, callback: (x: boolean) => void): void {
     $(el).on(
@@ -33,7 +33,7 @@ class ActionButtonInputBinding extends InputBinding {
         $el.data("val", val + 1);
 
         callback(false);
-      }
+      },
     );
   }
   getState(el: HTMLElement): { value: number } {
@@ -62,11 +62,11 @@ class ActionButtonInputBinding extends InputBinding {
 
       // update the requested properties
       if (hasDefinedProperty(data, "label")) {
-        label = data.label;
+        label = data.label!;
       }
       if (hasDefinedProperty(data, "icon")) {
         // `data.icon` can be an [] if user gave `character(0)`.
-        icon = Array.isArray(data.icon) ? "" : data.icon ?? "";
+        icon = Array.isArray(data.icon) ? "" : (data.icon ?? "");
       }
 
       // produce new html

srcts/src/bindings/input/checkbox.ts

@@ -34,21 +34,21 @@ class CheckboxInputBinding extends InputBinding {
   }
   receiveMessage(
     el: CheckedHTMLElement,
-    data: CheckboxReceiveMessageData
+    data: CheckboxReceiveMessageData,
   ): void {
     if (hasDefinedProperty(data, "value")) {
-      el.checked = data.value;
+      el.checked = data.value!;
     }
 
     // checkboxInput()'s label works different from other
     // input labels...the label container should always exist
     if (hasDefinedProperty(data, "label")) {
-      $(el).parent().find("span").text(data.label);
+      $(el).parent().find("span").text(data.label!);
     }
 
     $(el).trigger("change");
   }
 }
 
 export { CheckboxInputBinding };
-export type { CheckedHTMLElement, CheckboxReceiveMessageData };
+export type { CheckboxReceiveMessageData, CheckedHTMLElement };

srcts/src/bindings/input/checkboxgroup.ts

@@ -77,7 +77,7 @@ class CheckboxGroupInputBinding extends InputBinding {
             $escape(el.id) +
             '"][value="' +
             $escape(value[i]) +
-            '"]'
+            '"]',
         ).prop("checked", true);
       }
       // Else assume it's a single value
@@ -87,7 +87,7 @@ class CheckboxGroupInputBinding extends InputBinding {
           $escape(el.id) +
           '"][value="' +
           $escape(value) +
-          '"]'
+          '"]',
       ).prop("checked", true);
     }
   }
@@ -97,7 +97,7 @@ class CheckboxGroupInputBinding extends InputBinding {
     options: ValueLabelObject[];
   } {
     const $objs = $(
-      'input:checkbox[name="' + $escape(el.id) + '"]'
+      'input:checkbox[name="' + $escape(el.id) + '"]',
     ) as JQuery<CheckboxGroupHTMLElement>;
 
     // Store options in an array of objects, each with with value and label
@@ -115,7 +115,7 @@ class CheckboxGroupInputBinding extends InputBinding {
   }
   receiveMessage(
     el: CheckboxGroupHTMLElement,
-    data: CheckboxGroupReceiveMessageData
+    data: CheckboxGroupReceiveMessageData,
   ): void {
     const $el = $(el);
 
@@ -125,11 +125,11 @@ class CheckboxGroupInputBinding extends InputBinding {
       $el.find("div.shiny-options-group").remove();
       // Backward compatibility: for HTML generated by shinybootstrap2 package
       $el.find("label.checkbox").remove();
-      $el.append(data.options);
+      $el.append(data.options!);
     }
 
     if (hasDefinedProperty(data, "value")) {
-      this.setValue(el, data.value);
+      this.setValue(el, data.value!);
     }
 
     updateLabel(data.label, getLabelNode(el));
@@ -138,7 +138,7 @@ class CheckboxGroupInputBinding extends InputBinding {
   }
   subscribe(
     el: CheckboxGroupHTMLElement,
-    callback: (x: boolean) => void
+    callback: (x: boolean) => void,
   ): void {
     $(el).on("change.checkboxGroupInputBinding", function () {
       callback(false);

srcts/src/bindings/input/date.ts

@@ -15,10 +15,10 @@ declare global {
     bsDatepicker(methodName: "getUTCDate"): Date;
     // Infinity is not allowed as a literal return type. Using `1e9999` as a placeholder that resolves to Infinity
     // https://github.com/microsoft/TypeScript/issues/32277
-    // eslint-disable-next-line @typescript-eslint/no-loss-of-precision
-    bsDatepicker(methodName: "getStartDate"): Date | -1e9999;
-    // eslint-disable-next-line @typescript-eslint/no-loss-of-precision
-    bsDatepicker(methodName: "getEndDate"): Date | 1e9999;
+
+    bsDatepicker(methodName: "getStartDate"): Date | -1e9999; // eslint-disable-line no-loss-of-precision
+
+    bsDatepicker(methodName: "getEndDate"): Date | 1e9999; // eslint-disable-line no-loss-of-precision
     bsDatepicker(methodName: string): void;
     bsDatepicker(methodName: string, params: Date | null): void;
   }
@@ -37,7 +37,7 @@ class DateInputBindingBase extends InputBinding {
   }
   getType(el: HTMLElement): string {
     return "shiny.date";
-    el;
+    el; // eslint-disable-line @typescript-eslint/no-unused-expressions
   }
   subscribe(el: HTMLElement, callback: (x: boolean) => void): void {
     // Don't update when in the middle of typing; listening on keyup or input
@@ -50,7 +50,7 @@ class DateInputBindingBase extends InputBinding {
         // Send immediately when clicked
         // Or if typing, when enter pressed or focus lost
         callback(false);
-      }
+      },
     );
   }
   unsubscribe(el: HTMLElement): void {
@@ -66,8 +66,8 @@ class DateInputBindingBase extends InputBinding {
 
   setValue(el: HTMLElement, data: unknown): void {
     throw "not implemented";
-    el;
-    data;
+    el; // eslint-disable-line @typescript-eslint/no-unused-expressions
+    data; // eslint-disable-line @typescript-eslint/no-unused-expressions
   }
   initialize(el: HTMLElement): void {
     const $input = $(el).find("input");
@@ -297,14 +297,14 @@ class DateInputBinding extends DateInputBindingBase {
 
     updateLabel(data.label, this._getLabelNode(el));
 
-    if (hasDefinedProperty(data, "min")) this._setMin($input[0], data.min);
+    if (hasDefinedProperty(data, "min")) this._setMin($input[0], data.min!);
 
-    if (hasDefinedProperty(data, "max")) this._setMax($input[0], data.max);
+    if (hasDefinedProperty(data, "max")) this._setMax($input[0], data.max!);
 
     // Must set value only after min and max have been set. If new value is
     // outside the bounds of the previous min/max, then the result will be a
     // blank input.
-    if (hasDefinedProperty(data, "value")) this.setValue(el, data.value);
+    if (hasDefinedProperty(data, "value")) this.setValue(el, data.value!);
 
     $(el).trigger("change");
   }

srcts/src/bindings/input/daterange.ts

@@ -115,20 +115,20 @@ class DateRangeInputBinding extends DateInputBindingBase {
     updateLabel(data.label, getLabelNode(el));
 
     if (hasDefinedProperty(data, "min")) {
-      this._setMin($startinput[0], data.min);
-      this._setMin($endinput[0], data.min);
+      this._setMin($startinput[0], data.min!);
+      this._setMin($endinput[0], data.min!);
     }
 
     if (hasDefinedProperty(data, "max")) {
-      this._setMax($startinput[0], data.max);
-      this._setMax($endinput[0], data.max);
+      this._setMax($startinput[0], data.max!);
+      this._setMax($endinput[0], data.max!);
     }
 
     // Must set value only after min and max have been set. If new value is
     // outside the bounds of the previous min/max, then the result will be a
     // blank input.
     if (hasDefinedProperty(data, "value")) {
-      this.setValue(el, data.value);
+      this.setValue(el, data.value!);
     }
 
     $el.trigger("change");
@@ -171,7 +171,7 @@ class DateRangeInputBinding extends DateInputBindingBase {
         // Send immediately when clicked
         // Or if typing, when enter pressed or focus lost
         callback(false);
-      }
+      },
     );
   }
   unsubscribe(el: HTMLElement): void {

srcts/src/bindings/input/fileinput.ts

@@ -88,6 +88,7 @@ function canSetFiles(fileList: FileList): boolean {
     testEl.files = fileList;
   } catch (e) {
     return false;
+    e; // eslint-disable-line @typescript-eslint/no-unused-expressions
   }
   return true;
 }
@@ -99,7 +100,7 @@ function handleDrop(e: JQuery.DragEventBase, el: HTMLInputElement): void {
     // 1. The FileList object isn't supported by this browser, and
     // there's nothing else we can try. (< IE 10)
     console.log(
-      "Dropping files is not supported on this browser. (no FileList)"
+      "Dropping files is not supported on this browser. (no FileList)",
     );
   } else if (!canSetFiles(files)) {
     // 2. The browser doesn't support assigning a type=file input's .files
@@ -146,7 +147,7 @@ function abortCurrentUpload($el: JQuery<EventTarget>) {
 
 function uploadDroppedFilesIE10Plus(
   el: HTMLInputElement,
-  files: FileList
+  files: FileList,
 ): void {
   const $el = $(el);
 
@@ -158,7 +159,7 @@ function uploadDroppedFilesIE10Plus(
   // Start the new upload and put the uploader in 'currentUploader'.
   $el.data(
     "currentUploader",
-    new FileUploader(shinyShinyApp(), fileInputBindingGetId(el), files, el)
+    new FileUploader(shinyShinyApp(), fileInputBindingGetId(el), files, el),
   );
 }
 
@@ -178,7 +179,7 @@ function uploadFiles(evt: JQuery.DragEvent): void {
   // Start the new upload and put the uploader in 'currentUploader'.
   $el.data(
     "currentUploader",
-    new FileUploader(shinyShinyApp(), id, files, evt.target)
+    new FileUploader(shinyShinyApp(), id, files, evt.target),
   );
 }
 
@@ -237,17 +238,18 @@ class FileInputBinding extends InputBinding {
   }
   setValue(el: HTMLElement, value: void): void {
     // Not implemented
-    el;
-    value;
+    return;
+    el; // eslint-disable-line @typescript-eslint/no-unused-expressions
+    value; // eslint-disable-line @typescript-eslint/no-unused-expressions
   }
   getType(el: HTMLElement): string {
     // This will be used only when restoring a file from a saved state.
     return "shiny.file";
-    el;
+    el; // eslint-disable-line @typescript-eslint/no-unused-expressions
   }
 
   subscribe(el: HTMLInputElement, callback: (x: boolean) => void): void {
-    callback;
+    callback; // eslint-disable-line @typescript-eslint/no-unused-expressions
 
     $(el).on("change.fileInputBinding", uploadFiles);
     // Here we try to set up the necessary events for Drag and Drop ("DnD").
@@ -257,8 +259,9 @@ class FileInputBinding extends InputBinding {
 
     enableDraghover($zone).on({
       "draghover:enter.draghover": (e) => {
-        e;
         $zone.addClass(zoneOver);
+        return;
+        e; // eslint-disable-line @typescript-eslint/no-unused-expressions
       },
       "draghover:leave.draghover": (e) => {
         $zone.removeClass(zoneOver);
@@ -267,8 +270,9 @@ class FileInputBinding extends InputBinding {
         e.stopPropagation();
       },
       "draghover:drop.draghover": (e, dropEvent) => {
-        e;
         handleDrop(dropEvent, el);
+        return;
+        e; // eslint-disable-line @typescript-eslint/no-unused-expressions
       },
     });
   }

srcts/src/bindings/input/index.ts

@@ -31,7 +31,7 @@ function initInputBindings(): {
   inputBindings.register(new CheckboxInputBinding(), "shiny.checkboxInput");
   inputBindings.register(
     new CheckboxGroupInputBinding(),
-    "shiny.checkboxGroupInput"
+    "shiny.checkboxGroupInput",
   );
   inputBindings.register(new RadioInputBinding(), "shiny.radioInput");
   inputBindings.register(new SliderInputBinding(), "shiny.sliderInput");
@@ -40,11 +40,11 @@ function initInputBindings(): {
   inputBindings.register(new SelectInputBinding(), "shiny.selectInput");
   inputBindings.register(
     new ActionButtonInputBinding(),
-    "shiny.actionButtonInput"
+    "shiny.actionButtonInput",
   );
   inputBindings.register(
     new BootstrapTabInputBinding(),
-    "shiny.bootstrapTabInput"
+    "shiny.bootstrapTabInput",
   );
   const fileInputBinding = new FileInputBinding();