Skip to content

Commit 81bdde6

Browse files
wchcpsievert
andauthored
Convert bindAll to an async function (#3904)
Co-authored-by: Carson <[email protected]> Co-authored-by: cpsievert <[email protected]>
1 parent c4ef423 commit 81bdde6

File tree

22 files changed

+3745
-2298
lines changed

22 files changed

+3745
-2298
lines changed

.eslintrc.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@ parser: '@typescript-eslint/parser'
1515
parserOptions:
1616
ecmaVersion: 2018
1717
sourceType: module
18+
project:
19+
- './tsconfig.json'
20+
ignorePatterns: # mirrors tsconfig.json's exclude
21+
- '**/__tests__'
22+
- '**/*.d.ts'
1823
plugins:
1924
- '@typescript-eslint'
2025
- prettier
@@ -70,6 +75,10 @@ rules:
7075

7176
"@typescript-eslint/consistent-type-imports":
7277
- error
78+
79+
"@typescript-eslint/no-floating-promises":
80+
- error
81+
7382
"@typescript-eslint/naming-convention":
7483
- error
7584

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# shiny (development version)
22

3+
## Possibly breaking changes
4+
5+
* Closed #3899: The JS functions `Shiny.renderContent()` and `Shiny.bindAll()` are now asynchronous. These changes were motivated by the recent push toward making dynamic UI rendering asynchronous (and should've happened when it was first introduced in Shiny v1.7.5). The vast majority of user code using these functions should continue to work as before, but some code may break if it relies on these functions being synchronous (i.e., blocking downstream operations until completion). In this case, consider `await`-ing the downstream operations (or placing in a `.then()` callback). (#3929)
6+
37
## New features and improvements
48

59
* Updated `selectizeInput()`'s selectize.js dependency from v0.12.4 to v0.15.2. In addition to many bug fixes and improvements, this update also adds several new [plugin options](https://selectize.dev/docs/demos/plugins). (#3875)

0 commit comments

Comments
 (0)