v1.12.1 (#4329)

Author: schloerke

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: shiny
 Title: Web Application Framework for R
-Version: 1.12.0.9000
+Version: 1.12.1
 Authors@R: c(
     person("Winston", "Chang", , "winston@posit.co", role = "aut",
            comment = c(ORCID = "0000-0002-1576-2126")),

NEWS.md

@@ -1,8 +1,25 @@
-# shiny (development version)
+# shiny 1.12.1
+
+## New features
+
+* `withOtelCollect()` and `localOtelCollect()` temporarily control
+  OpenTelemetry collection levels during reactive expression creation,
+  allowing you to enable or disable telemetry collection for specific modules
+  or sections of code. (#4333)
+
+## Bug fixes and minor improvements
+
+* OpenTelemetry code attributes now include both the preferred attribute names
+  (`code.file.path`, `code.line.number`, `code.column.number`) and the
+  deprecated names (`code.filepath`, `code.lineno`, `code.column`) to follow
+  OpenTelemetry semantic conventions while maintaining backward compatibility.
+  The deprecated names will be removed in a future release after Logfire
+  supports the preferred names. (#4325)
+
+* `ExtendedTask` now captures the OpenTelemetry recording state at
+  initialization time rather than at invocation time, ensuring consistent span
+  recording behavior regardless of runtime configuration changes. (#4334)
 
-* `ExtendedTask` now captures the OpenTelemetry recording state at initialization time rather than at invocation time, ensuring consistent span recording behavior regardless of runtime configuration changes. (#4334)
-* Added `withOtelCollect()` and `localOtelCollect()` functions to temporarily control OpenTelemetry collection levels during reactive expression creation. These functions allow you to enable or disable telemetry collection for specific modules or sections of code where reactive expressions are being created. (#4333)
-* OpenTelemetry code attributes now include both preferred (`code.file.path`, `code.line.number`, `code.column.number`) and deprecated (`code.filepath`, `code.lineno`, `code.column`) attribute names to follow OpenTelemetry semantic conventions while maintaining backward compatibility. The deprecated names will be removed in a future release after Logfire supports the preferred names. (#4325)
 * Timer tests are now skipped on CRAN. (#4327)
 
 # shiny 1.12.0

cran-comments.md

@@ -1,121 +1,129 @@
 ## Comments
 
-#### 2025-12-01
+#### 2025-12-08
 
-Hi CRAN,
+Test has been removed from CRAN checks.
 
-We made changes to underlying structures that packages are not suppose to test. PRs were provided for each failing package.
+Also added a couple bug fixes as found by users.
 
-Maintainer change: From Winston Chang to Carson Sievert.
-
-Please let me know if you need any further information.
+Please let me know if you need any further changes.
 
 Thank you,
 Carson
 
-## `R CMD check` results:
+#### 2025-12-04
 
-The maintainer change is correctly detected. The URL check sometimes flags a 429
-error from Wikipedia, which is a temporary issue since the URL is valid when
-visited manually.
+Error:
 
 ```
-* checking CRAN incoming feasibility ... [19s] NOTE
-Maintainer: 'Carson Sievert <barret@posit.co>'
-
-New maintainer:
-  Carson Sievert <barret@posit.co>
-Old maintainer(s):
-  Winston Chang <winston@posit.co>
-
-Found the following (possibly) invalid URLs:
-  URL: https://en.wikipedia.org/wiki/Reactive_programming
-    From: README.md
-    Status: 429
-    Message: Too Many Requests
+Check Details
+Version: 1.12.0
+Check: tests
+Result: ERROR
+    Running ‘testthat.R’ [100s/394s]
+  Running the tests in ‘tests/testthat.R’ failed.
+  Complete output:
+    > library(testthat)
+    > library(shiny)
+    >
+    > test_check("shiny")
+    Saving _problems/test-timer-35.R
+    [ FAIL 1 | WARN 0 | SKIP 22 | PASS 1981 ]
+
+    ══ Skipped tests (22) ══════════════════════════════════════════════════════════
+    • File system is not case-sensitive (1): 'test-app.R:36:5'
+    • I'm not sure of a great way to test this without timers. (1):
+      'test-test-server.R:216:3'
+    • Not testing in CI (1): 'test-devmode.R:17:3'
+    • On CRAN (18): 'test-actionButton.R:59:1', 'test-busy-indication.R:1:1',
+      'test-busy-indication.R:15:1', 'test-busy-indication.R:50:1',
+      'test-otel-error.R:1:1', 'test-otel-mock.R:1:1', 'test-pkgdown.R:3:3',
+      'test-reactivity.r:146:1', 'test-reactivity.r:1240:5',
+      'test-reactivity.r:1240:5', 'test-stacks-deep.R:93:1',
+      'test-stacks-deep.R:141:1', 'test-stacks.R:140:3', 'test-tabPanel.R:46:1',
+      'test-tabPanel.R:66:1', 'test-tabPanel.R:73:1', 'test-tabPanel.R:83:1',
+      'test-utils.R:177:3'
+    • {shinytest2} is not installed (1): 'test-test-shinyAppTemplate.R:2:1'
+
+    ══ Failed tests ════════════════════════════════════════════════════════════════
+    ── Failure ('test-timer.R:35:3'): Unscheduling works ───────────────────────────
+    Expected `timerCallbacks$.times` to be identical to `origTimes`.
+    Differences:
+    `attr(actual, 'row.names')` is an integer vector ()
+    `attr(expected, 'row.names')` is a character vector ()
+
+
+    [ FAIL 1 | WARN 0 | SKIP 22 | PASS 1981 ]
+    Error:
+    ! Test failures.
+    Execution halted
 ```
 
 
-## Reverse dependency fixes
-
-The revdep checks below are failing due to changes made in https://github.com/rstudio/shiny/pull/4249 .
-
-Unresolved PRs submitted in 2025/06:
-* omicsTools    - https://github.com/cheemalab/omicsTools/pull/1
-* shinyGovstyle - https://github.com/dfe-analytical-services/shinyGovstyle/pull/155
-* ShinyLink     - https://github.com/cdc-addm/ShinyLink/pull/3
-* shinySbm      - https://github.com/Jo-Theo/shinySbm/pull/2
+#### 2025-12-03
 
-Unresolved PR submitted in 2025/10/29:
-* biodosetools - PR made 2025/10/29 - https://github.com/biodosetools-team/biodosetools/pull/64
-* inshiny      - PR made 2025/10/29 - https://github.com/nicholasdavies/inshiny/pull/1
-
-## Reverse dependency false positives
-
-* SouthParkRshiny - New NOTE about installed package size. This is unrelated to any new changes in Shiny.
-
-> ```
-> * checking installed package size ... NOTE
->   installed size is  8.6Mb
->   sub-directories of 1Mb or more:
->     data   8.0Mb
-> ```
+```
+Dear maintainer,
 
-## revdepcheck results
+Please see the problems shown on
+<https://cran.r-project.org/web/checks/check_results_shiny.html>.
 
-We checked 1395 reverse dependencies (1388 from CRAN + 7 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
+Please correct before 2025-12-17 to safely retain your package on CRAN.
 
- * We saw 7 new problems
- * We failed to check 21 packages
+The CRAN Team
+```
 
-Issues with CRAN packages are summarised below.
+## `R CMD check` results:
 
-### New problems
-(This reports the first line of each new failure)
+0 errors | 0 warning | 1 note
 
-* biodosetools
-  checking tests ... ERROR
+```
+─  checking CRAN incoming feasibility ... [7s/70s] NOTE (1m 9.5s)
+   Maintainer: ‘Carson Sievert <carson@posit.co>’
 
-* inshiny
-  checking examples ... ERROR
-  checking tests ... ERROR
-  checking re-building of vignette outputs ... ERROR
+   Days since last update: 5
+```
 
-* omicsTools
-  checking tests ... ERROR
 
-* shinyGovstyle
-  checking tests ... ERROR
+## revdepcheck results
 
-* ShinyLink
-  checking tests ... ERROR
+We checked 1383 reverse dependencies (1376 from CRAN + 7 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
 
-* shinySbm
-  checking tests ... ERROR
+ * We saw 0 new problems
+ * We failed to check 31 packages
 
-* SouthParkRshiny
-  checking installed package size ... NOTE
+Issues with CRAN packages are summarised below.
 
 ### Failed to check
 
+* AssumpSure
 * boinet
+* brms
+* cheem
 * ctsem
+* detourr
 * FAfA
 * fio
+* fitteR
 * FossilSimShiny
 * GDINA
 * ggsem
 * grandR
 * hbsaems
+* langevitour
 * lavaan.shiny
 * lcsm
 * linkspotter
 * loon.shiny
 * MOsemiind
 * MVN
+* pandemonium
+* polarisR
 * RCTrep
 * rstanarm
 * semdrw
+* shotGroups
 * sphereML
+* spinifex
 * SurprisalAnalysis
 * TestAnaAPP