updated tests

Author: bborgesr

tests-manual/trigger-shown-sidebar.R

@@ -1,49 +1,20 @@
 # Run this app to test that Shiny outputs that are initally hidden inside
 # menuItems become visible ( trigger("shown) ) after we expand the respective
-# menuItem. Currently, this doesn't look exactly pretty, but it does work.
-#
-# ------------------------------------------------------------------------------
-#
-# Aside from being ugly, this app also shows another unfortunate side effect
-# of the hacky code for the trigger("shown) of Shiny outputs. Which is that
-# the ensureActivatedTab() function does not work on app startup if the only
-# tabNamed things are initially hidden inside the menuItem parents.
-#
-# To see this, go to this app URL:
-# http://127.0.0.1:4601/?_inputs_&sidebarCollapsed=%22false%22&sidebarItemExpanded=%22tabName%22&smenu=null
-# You will see that even though `smenu` is "null" the `name` tab (menuSubItem)
-# appears highlighted, as it should be if the ensureActivatedTab() function is
-# doing its job.
-# But if you do this "manually", even though you get the *SAME* bookmarked URL,
-# you don't see the `name` tab highlighted...:
-#     1) Go to http://127.0.0.1:4601/
-#     2) Click on the "Menu Item 1" to expand it
-#     3) Check with abadonment and dismay that the URL looks the same as above,
-#        but that the `name` tab is *NOT* highlighted
-#     4) Regain some faith and hope through the fact that at least the content
-#        ("This is the only content") always appears, so while something if off
-#        with ensureActivatedTab(), it's still doing its most important job,
-#        which is to display some/any content on the dashboardBody if there is
-#        a menuItem or menuSubItem anywhere in the dashboardSidebar with a
-#        tabName and a corresponding tabItem anywhere in the dashboardBody
-#
-# ------------------------------------------------------------------------------
-#
-# This also shows that you can only bookmark the expanded menuItem *IF* at least
-# one of its children is a menuSubItem *with* a tabName.
+# menuItem.
 
 library(shiny)
 library(shinydashboard)
 
-options(shiny.launch.browser=F, shiny.minified=F, shiny.port = 4601)
+options(shiny.launch.browser=F, shiny.minified=F, shiny.port = 9000)
 
 ui <- function(req) {
   dashboardPage(
     dashboardHeader(),
     dashboardSidebar(
       sidebarMenu(id = "smenu",
         menuItem("Menu Item 1", tabName = "tab1", "text1", menuSubItem("name", tabName = "tabName")),
-        menuItem("Menu Item 2", tabName = "tab2", textOutput("text2"))
+        menuItem("Menu Item 2", tabName = "tab2", textOutput("text2"), startExpanded = FALSE,
+          expandedName = "expanded")
       )
     ),
     dashboardBody(

tests-manual/updateTabItems.R

@@ -1,36 +1,36 @@
 ## This creates dashboard with a sidebar. The sidebar has a button which allows to switch between different
 ## panels (tabs) within the same dashboard
 
-  ui <- dashboardPage(
-    dashboardHeader(title = "Simple tabs"),
-    dashboardSidebar(
-      sidebarMenu(
-        id = "tabs",
-        menuItem("Dashboard", tabName = "dashboard", icon = icon("dashboard")),
-        menuItem("Widgets", tabName = "widgets", icon = icon("th"))
-      ),
-      actionButton('switchtab', 'Switch tab')
+library(shinydashboard)
+library(shiny)
+
+options(shiny.launch.browser=F, shiny.minified=F, shiny.port = 9000)
+
+ui <- dashboardPage(
+  dashboardHeader(title = "Simple tabs"),
+  dashboardSidebar(
+    sidebarMenu(id = "tabs",
+      menuItem("Dashboard", tabName = "dashboard", icon = icon("dashboard")),
+      menuItem("Widgets", tabName = "widgets", icon = icon("th"))
     ),
-    dashboardBody(
-      tabItems(
-        tabItem(tabName = "dashboard",
-                h2("Dashboard tab content")
-        ),
-        tabItem(tabName = "widgets",
-                h2("Widgets tab content")
-        )
-      )
+    actionButton('switchtab', 'Switch tab')
+  ),
+  dashboardBody(
+    tabItems(
+      tabItem(tabName = "dashboard", h2("Dashboard tab content")),
+      tabItem(tabName = "widgets", h2("Widgets tab content"))
     )
   )
+)
 
-  server <- function(input, output, session) {
-    observeEvent(input$switchtab, {
-      newtab <- switch(input$tabs,
-                       "dashboard" = "widgets",
-                       "widgets" = "dashboard"
-      )
-      updateTabItems(session, "tabs", newtab)
-    })
-  }
+server <- function(input, output, session) {
+  observeEvent(input$switchtab, {
+    newtab <- switch(input$tabs,
+      "dashboard" = "widgets",
+      "widgets" = "dashboard"
+    )
+    updateTabItems(session, "tabs", newtab)
+  })
+}
 
-  shinyApp(ui, server)
+shinyApp(ui, server)