Skip to content

Commit be67513

Browse files
authored
Add test for hywiki-mode (#839)
1 parent 82f7e0d commit be67513

File tree

3 files changed

+30
-5
lines changed

3 files changed

+30
-5
lines changed

ChangeLog

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
2026-01-07 Mats Lidell <matsl@gnu.org>
2+
3+
* hywiki.el (hywiki-mode): Remove arg value :toggle, not an alternative to
4+
'toggle.
5+
6+
* test/hywiki-tests.el (hywiki-test--hywiki-mode): Add test for hywiki-mode.
7+
18
2025-12-31 Mats Lidell <matsl@gnu.org>
29

310
* Remove starting asterix from defcustom variable docstrings.

hywiki.el

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
;; Author: Bob Weiner
44
;;
55
;; Orig-Date: 21-Apr-24 at 22:41:13
6-
;; Last-Mod: 30-Nov-25 at 18:06:52 by Bob Weiner
6+
;; Last-Mod: 7-Jan-26 at 15:26:05 by Mats Lidell
77
;;
88
;; SPDX-License-Identifier: GPL-3.0-or-later
99
;;
10-
;; Copyright (C) 2024-2025 Free Software Foundation, Inc.
10+
;; Copyright (C) 2024-2026 Free Software Foundation, Inc.
1111
;; See the "HY-COPY" file for license information.
1212
;;
1313
;; This file is part of GNU Hyperbole.
@@ -801,9 +801,9 @@ See the Info documentation at \"(hyperbole)HyWiki\".
801801
:keymap hywiki-mode-map
802802
:group 'hyperbole-hywiki
803803
(progn
804-
(when (memq arg '(toggle :toggle))
804+
(when (eq arg 'toggle)
805805
;; Toggle across all editable buffers
806-
(setq arg (if hywiki-mode 1 0)))
806+
(setq arg hywiki-mode))
807807
(cond
808808
((or (and (integerp arg) (= arg 1))
809809
(memq arg '(:all t)))

test/hywiki-tests.el

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
;;
88
;; SPDX-License-Identifier: GPL-3.0-or-later
99
;;
10-
;; Copyright (C) 2024-2025 Free Software Foundation, Inc.
10+
;; Copyright (C) 2024-2026 Free Software Foundation, Inc.
1111
;; See the "HY-COPY" file for license information.
1212
;;
1313
;; This file is part of GNU Hyperbole.
@@ -2141,6 +2141,24 @@ expected result."
21412141
(hy-delete-files-and-buffers (list wikiHi wikiHo))
21422142
(hywiki-tests--delete-hywiki-dir-and-buffer hywiki-directory)))))
21432143

2144+
(ert-deftest hywiki-test--hywiki-mode ()
2145+
"Verify activating local and global `hywiki-mode'."
2146+
(hywiki-tests--preserve-hywiki-mode
2147+
(with-temp-buffer
2148+
(should (eq nil (hywiki-mode 0)))
2149+
(should (eq nil (hywiki-mode -1)))
2150+
(should (eq nil (hywiki-mode nil)))
2151+
(should (eq :pages (hywiki-mode 2)))
2152+
(should (eq :all (hywiki-mode 1)))
2153+
(should (eq :all (hywiki-mode t)))
2154+
(should (eq :all (hywiki-mode :all)))
2155+
2156+
;; Toggle
2157+
(should (eq nil (call-interactively #'hywiki-mode)))
2158+
(should (eq :all (call-interactively #'hywiki-mode)))
2159+
(should (eq nil (hywiki-mode 'toggle)))
2160+
(should (eq :all (hywiki-mode 'toggle))))))
2161+
21442162
(ert-deftest hywiki-tests--interactive-hywiki-mode-toggles ()
21452163
"Verify `hywiki-mode' called interactively toggles mode."
21462164
(hywiki-tests--preserve-hywiki-mode

0 commit comments

Comments
 (0)