Merge pull request #7 from rtCamp/feature/admin-logo

Feature: Add admin logo & fix PHPCS issues

Author: up1512001

assets/images/logo.svg

@@ -54,3 +54,12 @@
 .hidden-logo-url {
 	display: none;
 }
+
+
+// add icon to the OneDesign admin menu
+[id="toplevel_page_onedesign"] {
+
+	.dashicons-admin-generic::before{
+		content: url("../../images/logo.svg") !important;
+	}
+}

assets/src/css/admin.scss

@@ -32,6 +32,17 @@ protected function __construct() {
 	 */
 	public function setup_hooks(): void {
 		add_action( 'enqueue_block_editor_assets', array( $this, 'enqueue_scripts' ), 20, 1 );
+		add_action( 'admin_enqueue_scripts', array( $this, 'add_admin_scripts' ), 20, 1 );
+	}
+
+	/**
+	 * Add admin scripts.
+	 *
+	 * @return void
+	 */
+	public function add_admin_scripts(): void {
+		$this->register_style( 'onedesign-admin-style', 'css/admin.css' );
+		wp_enqueue_style( 'onedesign-admin-style' );
 	}
 
 	/**

inc/classes/class-assets.php

@@ -370,7 +370,7 @@ public function remove_consumer_site_patterns( WP_REST_Request $request ): WP_Er
 			return new WP_Error( 'invalid_params', __( 'Pattern names must be provided as an array.', 'onedesign' ), array( 'status' => 400 ) );
 		}
 
-		// Remove the patterns from the consumer site patterns option
+		// Remove the patterns from the consumer site patterns option.
 		$consumer_patterns = get_option( 'consumer_site_patterns', array() );
 		if ( empty( $consumer_patterns ) ) {
 			return new WP_Error( 'no_patterns_found', __( 'No patterns found for this consumer site.', 'onedesign' ), array( 'status' => 404 ) );
@@ -675,7 +675,7 @@ function ( $site ) use ( $site_id ) {
 				}
 			);
 
-			$target_site = reset( $target_site ); // Get the first match, should be unique by ID
+			$target_site = reset( $target_site ); // Get the first match, should be unique by ID.
 
 			if ( empty( $target_site ) ) {
 				$results[ $site_id ] = array(
@@ -782,15 +782,15 @@ private function get_all_local_patterns_map(): array {
 			}
 		}
 
-		// Get all registered patterns
+		// Get all registered patterns.
 		$registered_patterns = \WP_Block_Patterns_Registry::get_instance()->get_all_registered();
 
 		foreach ( $registered_patterns as $pattern ) {
 			if ( false === $pattern['inserter'] ) {
 				continue; // Skip patterns not intended for inserter.
 			}
 
-			// Map pattern category name to labels
+			// Map pattern category name to labels.
 			$pattern['category_labels'] = array();
 			if ( ! empty( $pattern['categories'] ) && is_array( $pattern['categories'] ) ) {
 				foreach ( $pattern['categories'] as $category_name ) {

inc/classes/class-rest.php

@@ -82,7 +82,7 @@ public function add_settings_page(): void {
 			'manage_options',
 			self::PAGE_SLUG,
 			'__return_null',
-			'dashicons-admin-generic',
+			'',
 			100
 		);
 
@@ -127,12 +127,12 @@ public function handle_design_library_redirect(): void {
 			return;
 		}
 
-		// Only run for users with proper permissions
+		// Only run for users with proper permissions.
 		if ( ! current_user_can( 'manage_options' ) ) {
 			return;
 		}
 
-		// Your existing create/redirect logic here
+		// Your existing create/redirect logic here.
 		$this->create_and_open_design_library_post();
 	}
 
@@ -324,16 +324,16 @@ public function handle_form_actions(): void {
 
 		// Handle child sites update for dashboard sites.
 		if ( isset( $_POST['child_sites'] ) && get_option( self::OPTION_SITE_TYPE ) === 'dashboard' ) {
-			$child_sites = array();
-
-			foreach ( $_POST['child_sites'] as $site_data ) {
+			$child_sites      = array();
+			$post_child_sites = $_POST['child_sites'] ?? array(); // phpcs:ignore -- sites info is sanitized below.
+			foreach ( $post_child_sites as $site_data ) {
 				$site_id      = isset( $site_data['id'] ) ? sanitize_text_field( $site_data['id'] ) : '';
 				$site_name    = isset( $site_data['name'] ) ? sanitize_text_field( $site_data['name'] ) : '';
 				$site_url     = isset( $site_data['url'] ) ? esc_url_raw( $site_data['url'] ) : '';
 				$site_logo    = isset( $site_data['logo'] ) ? esc_url_raw( $site_data['logo'] ) : '';
 				$site_api_key = isset( $site_data['api_key'] ) ? sanitize_text_field( $site_data['api_key'] ) : '';
 
-				// Only save if all fields are filled
+				// Only save if all fields are filled.
 				if ( ! empty( $site_name ) && ! empty( $site_url ) && ! empty( $site_api_key ) ) {
 					$child_sites[] = array(
 						'id'      => $site_id,