Skip to content

Commit 8816f88

Browse files
authored
Merge pull request #50 from rtCamp/fix/gh-pages-workflow
Fix: Github Pages deployment workflow
2 parents 6d80842 + 55fb95e commit 8816f88

File tree

2 files changed

+44
-33
lines changed

2 files changed

+44
-33
lines changed

.github/workflows/deploy.yaml

Lines changed: 43 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,47 +1,58 @@
1-
name: Publish To Github Pages
1+
name: Deploy Storybook to GitHub Pages
22

33
on:
44
push:
5-
branches: ["main"]
5+
branches: [ main ]
6+
workflow_dispatch:
67

7-
env:
8-
CI: false
8+
permissions:
9+
contents: read
10+
pages: write
11+
id-token: write
12+
13+
concurrency:
14+
group: "pages"
15+
cancel-in-progress: true
916

1017
jobs:
1118
build:
1219
runs-on: ubuntu-latest
13-
environment:
14-
name: github-pages
15-
url: ${{ steps.deployment.outputs.page_url }}
16-
17-
permissions:
18-
contents: "read"
19-
id-token: "write"
20-
pages: "write"
21-
actions: "write"
22-
checks: "write"
23-
deployments: "write"
24-
strategy:
25-
matrix:
26-
node-version: [20.x]
27-
2820
steps:
29-
- name: Checkout
30-
uses: actions/checkout@v3
31-
- name: Setup Node
32-
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c
21+
- name: Checkout repository
22+
uses: actions/checkout@v4
23+
24+
- name: Setup Node.js
25+
uses: actions/setup-node@v4
3326
with:
34-
node-version-file: ".nvmrc"
35-
cache: npm
27+
node-version-file: '.nvmrc'
28+
cache: 'npm'
29+
3630
- name: Install dependencies
3731
run: |
38-
npm ci
32+
ls
33+
pwd
34+
rm -rf **/node_modules
35+
rm -rf package-lock.json
36+
npm install || true
37+
3938
- name: Build Storybook
40-
run: |
41-
npm run build-storybook
39+
run: npm run build-storybook
40+
41+
- name: Setup Pages
42+
uses: actions/configure-pages@v5
4243

43-
- name: Deploy
44-
uses: peaceiris/actions-gh-pages@v4
44+
- name: Upload artifact
45+
uses: actions/upload-pages-artifact@v3
4546
with:
46-
github_token: ${{ secrets.GITHUB_TOKEN }}
47-
publish_dir: ./storybook-static
47+
path: './storybook-static'
48+
49+
deploy:
50+
needs: build
51+
environment:
52+
name: github-pages
53+
url: ${{ steps.deployment.outputs.page_url }}
54+
runs-on: ubuntu-latest
55+
steps:
56+
- name: Deploy to GitHub Pages
57+
id: deployment
58+
uses: actions/deploy-pages@v4

packages/frappe-ui-react/src/components/spinner/spinner.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import './Spinner.css';
1+
import './spinner.css';
22

33
interface SpinnerProps {
44
className?: string;

0 commit comments

Comments
 (0)