Skip to content

Commit 9abfa83

Browse files
committed
Fix: enhance styles for rating, switch, and tab buttons components
1 parent c1ea3f2 commit 9abfa83

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

packages/frappe-ui-react/src/components/rating/rating.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const Rating: React.FC<RatingProps> = ({
3535
size === "xl" ? "size-7" : "",
3636
index <= hoveredRating && index > rating ? "!fill-yellow-200" : "",
3737
index <= rating ? "!fill-yellow-500" : "",
38-
index > rating && index > hoveredRating ? "fill-gray-300" : "",
38+
index > rating && index > hoveredRating ? "fill-gray-300 dark:fill-gray-900" : "",
3939
!readonly ? "cursor-pointer" : "",
4040
"text-transparent",
4141
"mr-0.5",

packages/frappe-ui-react/src/components/switch/switch.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const Switch: React.FC<SwitchProps> = ({
3636
"disabled:cursor-not-allowed disabled:bg-surface-gray-3",
3737
value
3838
? "bg-surface-gray-7 enabled:hover:bg-surface-gray-6 active:bg-surface-gray-5 group-hover:enabled:bg-surface-gray-6"
39-
: "bg-surface-gray-4 enabled:hover:bg-gray-400 active:bg-gray-500 group-hover:enabled:bg-gray-400",
39+
: "bg-surface-gray-4 enabled:hover:bg-gray-800 active:bg-gray-500 group-hover:enabled:bg-gray-800",
4040
size === "md" ? "h-5 w-8 border-[3px]" : "h-4 w-[26px] border-2",
4141
].join(" ");
4242

@@ -75,7 +75,7 @@ const Switch: React.FC<SwitchProps> = ({
7575
);
7676
classes.push(size === "md" ? "px-3 py-1.5" : "px-2.5 py-1.5");
7777
} else if (switchType === SwitchVariant.WITH_LABEL_AND_DESCRIPTION) {
78-
classes.push("items-start");
78+
classes.push("group items-start");
7979
classes.push(size === "md" ? "space-x-3.5" : "space-x-2.5");
8080
}
8181
return classes.join(" ");

packages/frappe-ui-react/src/components/tabButtons/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const TabButtons = ({
2727
}: TabButtonsProps) => {
2828
return (
2929
<RadioGroup value={value} onChange={onChange} className={className}>
30-
<div className="flex space-x-0.5 rounded-md bg-surface-gray-2 h-7 items-center px-[1px] text-sm">
30+
<div className="flex space-x-0.5 rounded-md bg-surface-gray-2 h-7 items-center px-[1px] text-sm border border-gray-200">
3131
{buttons.map((button) => (
3232
<Radio
3333
key={button.value || button.label}

0 commit comments

Comments
 (0)