Add condition before execution of the endpoint validate (#218)

Control dimensions of the matrix only if a time series is provided by the user in edition mode

Author: KKamel67

NEWS.md

@@ -14,6 +14,7 @@ NEW FEATURES :
   - **New properties** (*efficiencywithdrawal*, *penalize-variation-injection*, *penalize-variation-withdrawal*, see list of properties according to study version of Antares with `storage_values_default()`)  
   - **New optional time series** (cost-injection, cost-withdrawal, cost-level, cost-variation-injection, cost-variation-withdrawal)
 * `updateScenarioBuilder()` New type of series "hfl" ("hydro final level", similar to "hydrolevels") is available   
+* `editBindingConstraint()` : control the dimemnsions of the matrix only if a time series is provided by the user for optimization
 
 
 ### Breaking changes  :  

R/editBindingConstraint.R

@@ -292,6 +292,7 @@ editBindingConstraint <- function(name,
 
 # api part code
 .editBC_api <- function(..., opts){
+  
   body <- list(...)
   # checks for any study version (legacy)
   if (is.null(body$time_step))
@@ -333,9 +334,9 @@ editBindingConstraint <- function(name,
   }
 
   # >=v870
-  
+  with_time_series <- !is.null(body$values)  
   # reforge list structure
-  if(!is.null(body$values)){
+  if (with_time_series) {
     list_values <- list(less_term_matrix = body$values$lt,
                         equal_term_matrix = body$values$eq,
                         greater_term_matrix = body$values$gt)
@@ -405,12 +406,15 @@ editBindingConstraint <- function(name,
           body = body, 
           encode = "raw")
 
-  # /validate 
-  api_get(opts = opts, 
-          endpoint = file.path(opts$study_id, 
-                               "constraint-groups",
-                               result$group, 
-                               "validate"))
+  # /validate only if user provides a time series for optimization reason
+  if (with_time_series) {
+    api_get(opts = opts, 
+            endpoint = file.path(opts$study_id, 
+                                 "constraint-groups",
+                                 result$group, 
+                                 "validate")
+            )
+  }
 
   # specific endpoint for coeffs/terms
   if(!is.null(body_terms))