Allow sending request with different methods during connection (#66)

* Allow sending request with different methods during connection, add unit test, update the doc

* Fix test

Co-authored-by: Pavel Filatov <[email protected]>
Co-authored-by: Jason Hu <[email protected]>

Author: 3 people

aiohttp_sse_client/client.py

@@ -69,16 +69,18 @@ def __init__(self, url: str,
 
         :param url: specifies the URL to which to connect
         :param option: specifies the settings, if any,
-            in the form of an Dict[str, Any]. Reserved for future use
+            in the form of an Dict[str, Any]. Accept the "method" key for
+            specifying the HTTP method with which connection
+            should be established
         :param reconnection_time: wait time before try to reconnect in case
             connection broken
         :param session: specifies a aiohttp.ClientSession, if not, create
             a default ClientSession
         :param on_open: event handler for open event
         :param on_message: event handler for message event
         :param on_error: event handler for error event
-        :param kwargs: keyword arguments will pass to underlying aiohttp get()
-            method.
+        :param kwargs: keyword arguments will pass to underlying
+            aiohttp request() method.
         """
         self._url = URL(url)
         self._ready_state = READY_STATE_CONNECTING
@@ -109,6 +111,8 @@ def __init__(self, url: str,
         self._origin = None
         self._response = None
 
+        self._method = 'GET' if option is None else option.get('method', 'GET')
+
     def __enter__(self):
         """Use async with instead."""
         raise TypeError("Use async with instead")
@@ -207,7 +211,11 @@ async def connect(self, retry=0):
         headers[hdrs.CACHE_CONTROL] = 'no-cache'
 
         try:
-            response = await self._session.get(self._url, **self._kwargs)
+            response = await self._session.request(
+                self._method,
+                self._url,
+                **self._kwargs
+            )
         except ClientConnectionError:
             if retry <= 0 or self._ready_state == READY_STATE_CLOSED:
                 await self._fail_connect()

tests/web_platform_tests/test_request.py

@@ -1,16 +1,16 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
-from datetime import datetime, timedelta
 
 import pytest
 
 from aiohttp_sse_client import client as sse_client
 
 from .const import WPT_SERVER
 
+
 async def test_rquest_accept():
     """Test EventSource: Accept header.
-    
+
     ..seealso: https://github.com/web-platform-tests/wpt/blob/master/
     eventsource/request-accept.htm
     """
@@ -25,7 +25,7 @@ async def test_rquest_accept():
 
 async def test_rquest_cache_control():
     """Test EventSource: Cache-Control.
-    
+
     ..seealso: https://github.com/web-platform-tests/wpt/blob/master/
     eventsource/request-cache-control.htm
     """
@@ -40,14 +40,14 @@ async def test_rquest_cache_control():
 
 async def test_rquest_redirect():
     """Test EventSource: redirect.
-    
+
     ..seealso: https://github.com/web-platform-tests/wpt/blob/master/
     eventsource/request-redirect.htm
     """
     async def test(status):
         def on_error():
             assert False
-        
+
         def on_open():
             assert source.ready_state == sse_client.READY_STATE_OPEN
 
@@ -68,7 +68,7 @@ def on_open():
 
 async def test_rquest_status_error():
     """Test EventSource: redirect.
-    
+
     ..seealso: https://github.com/web-platform-tests/wpt/blob/master/
     eventsource/request-status-error.htm
     """
@@ -93,3 +93,17 @@ def on_message():
     await test(404)
     await test(410)
     await test(503)
+
+
+async def test_request_post_to_connect():
+    """Test EventSource option method for connection.
+    """
+    source = sse_client.EventSource(
+        WPT_SERVER + 'resources/message.py',
+        option={'method': "POST"}
+    )
+    await source.connect()
+    async for e in source:
+        assert e.data == "data"
+        break
+    await source.close()