Skip to content

Commit 8462e52

Browse files
authored
Merge pull request #325 from campersau/escape_header
escape diff headers for html
2 parents 12bf306 + 406be9f commit 8462e52

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/__tests__/diff2html-tests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,7 @@ describe('Diff2Html', () => {
723723
<tr>
724724
<td class=\\"d2h-code-linenumber d2h-info\\"></td>
725725
<td class=\\"d2h-info\\">
726-
<div class=\\"d2h-code-line d2h-info\\">@@ -11,7 +10,7 @@ $a=&quot;&lt;table&gt;&lt;tr&gt;&lt;td&gt;- 1.1.9: Fix around ubuntu&#x27;s inability to cache promises. [#8</div>
726+
<div class=\\"d2h-code-line d2h-info\\">@@ -11,7 +10,7 @@ $a=&amp;quot;&amp;lt;table&amp;gt;&amp;lt;tr&amp;gt;&amp;lt;td&amp;gt;- 1.1.9: Fix around ubuntu&amp;#x27;s inability to cache promises. [#8</div>
727727
</td>
728728
</tr><tr>
729729
<td class=\\"d2h-code-linenumber d2h-cntx\\">

src/line-by-line-renderer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export default class LineByLineRenderer {
9595
.map(block => {
9696
let lines = this.hoganUtils.render(genericTemplatesPath, 'block-header', {
9797
CSSLineClass: renderUtils.CSSLineClass,
98-
blockHeader: block.header,
98+
blockHeader: renderUtils.escapeForHtml(block.header),
9999
lineClass: 'd2h-code-linenumber',
100100
contentClass: 'd2h-code-line',
101101
});

src/side-by-side-renderer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ export default class SideBySideRenderer {
206206
makeHeaderHtml(blockHeader: string): string {
207207
return this.hoganUtils.render(genericTemplatesPath, 'block-header', {
208208
CSSLineClass: renderUtils.CSSLineClass,
209-
blockHeader: blockHeader,
209+
blockHeader: renderUtils.escapeForHtml(blockHeader),
210210
lineClass: 'd2h-code-side-linenumber',
211211
contentClass: 'd2h-code-side-line',
212212
});

0 commit comments

Comments
 (0)