Split build target into smaller, reusable ones

Doing so means we now can reuse the logic that fixes the include::
directives in the cpython documentation in our CI job, avoiding
repeating ourselves, making maintenance easier and avoiding subtle bugs.

Being able to reuse the rest of the steps (do_build, pospell, etc)
requires more care, as the Makefile is constrained to requiring a
virtual environment (which we don't create on CI), and also doesn't
allow us to pass command-line arguments to list specific files to check.

Signed-off-by: Rodrigo Tobar <[email protected]>

Author: rtobar

.github/workflows/main.yml

@@ -88,13 +88,6 @@ jobs:
       # Construcción de la documentación
       - name: Construir documentación
         run: |
-          # FIXME: Relative paths for includes in 'cpython'
-          sed -i -e 's|.. include:: ../includes/wasm-notavail.rst|.. include:: ../../../../includes/wasm-notavail.rst|g' cpython/Doc/**/*.rst
-          sed -i -e 's|.. include:: ../distutils/_setuptools_disclaimer.rst|.. include:: ../../../../distutils/_setuptools_disclaimer.rst|g' cpython/Doc/**/*.rst
-          sed -i -e 's|.. include:: ./_setuptools_disclaimer.rst|.. include:: ../../../_setuptools_disclaimer.rst|g' cpython/Doc/**/*.rst
-          sed -i -e 's|.. include:: token-list.inc|.. include:: ../../../token-list.inc|g' cpython/Doc/**/*.rst
-          sed -i -e 's|.. include:: ../../using/venv-create.inc|.. include:: ../using/venv-create.inc|g' cpython/Doc/**/*.rst
-          sed -i -e 's|.. include:: ../../../using/venv-create.inc|.. include:: ../../using/venv-create.inc|g' cpython/Doc/**/*.rst
-          sed -i -e 's|.. include:: /using/venv-create.inc|.. include:: ../../../../using/venv-create.inc|g' cpython/Doc/**/*.rst
+          make fix_relative_paths
           # Normal build
           PYTHONWARNINGS=ignore::FutureWarning,ignore::RuntimeWarning sphinx-build -j auto -W --keep-going -b html -d cpython/Doc/_build/doctree -D language=es . cpython/Doc/_build/html

Makefile

@@ -38,7 +38,17 @@ help:
 #        before this. If passing SPHINXERRORHANDLING='', warnings will not be
 #        treated as errors, which is good to skip simple Sphinx syntax mistakes.
 .PHONY: build
-build: setup
+build: setup fix_relative_paths do_build
+
+.PHONY: do_build
+do_build:
+	# Normal build
+	PYTHONWARNINGS=ignore::FutureWarning,ignore::RuntimeWarning $(VENV)/bin/sphinx-build -j auto -W --keep-going -b html -d $(OUTPUT_DOCTREE) -D language=$(LANGUAGE) . $(OUTPUT_HTML) && \
+		echo "Success! Open file://`pwd`/$(OUTPUT_HTML)/index.html, " \
+			"or run 'make serve' to see them in http://localhost:8000";
+
+.PHONY: fix_relative_paths
+fix_relative_paths:
 	# FIXME: Relative paths for includes in 'cpython'
 	# See more about this at https://github.com/python/python-docs-es/issues/1844
 	sed -i -e 's|.. include:: ../includes/wasm-notavail.rst|.. include:: ../../../../includes/wasm-notavail.rst|g' cpython/Doc/**/*.rst
@@ -48,11 +58,6 @@ build: setup
 	sed -i -e 's|.. include:: ../../using/venv-create.inc|.. include:: ../using/venv-create.inc|g' cpython/Doc/**/*.rst
 	sed -i -e 's|.. include:: ../../../using/venv-create.inc|.. include:: ../../using/venv-create.inc|g' cpython/Doc/**/*.rst
 	sed -i -e 's|.. include:: /using/venv-create.inc|.. include:: ../../../../using/venv-create.inc|g' cpython/Doc/**/*.rst
-	# Normal build
-	PYTHONWARNINGS=ignore::FutureWarning,ignore::RuntimeWarning $(VENV)/bin/sphinx-build -j auto -W --keep-going -b html -d $(OUTPUT_DOCTREE) -D language=$(LANGUAGE) . $(OUTPUT_HTML) && \
-		echo "Success! Open file://`pwd`/$(OUTPUT_HTML)/index.html, " \
-			"or run 'make serve' to see them in http://localhost:8000";
-
 
 # setup: After running "venv" target, prepare that virtual environment with
 #        a local clone of cpython repository and the translation files.