Very important tweak - no subclasses of ObjectInserter are threadsafe

rtyley · rtyley · commit 0fde8d7ada4c · 2015-09-30T09:43:37.000+01:00
The blobId was only used in BFG test code, not in any released impl code,
thankfully.
diff --git a/scala-git/src/main/scala/com/madgag/git/package.scala b/scala-git/src/main/scala/com/madgag/git/package.scala
@@ -41,10 +41,8 @@ import scala.util.{Success, Try}
 
 package object git {
 
-  val ObjectFormatter = new Formatter
-
   implicit class RichByteArray(bytes: Array[Byte]) {
-    lazy val blobId = ObjectFormatter.idFor(OBJ_BLOB, bytes)
+    lazy val blobId = (new Formatter).idFor(OBJ_BLOB, bytes)
   }
 
   def storeBlob(bytes: Array[Byte])(implicit i: ObjectInserter): ObjectId = i.insert(OBJ_BLOB, bytes)

Original file line number	Diff line number	Diff line change
`@@ -41,10 +41,8 @@ import scala.util.{Success, Try}`
`41`	`41`
`42`	`42`	`package object git {`
`43`	`43`
`44`		`- val ObjectFormatter = new Formatter`
`45`		`-`
`46`	`44`	`implicit class RichByteArray(bytes: Array[Byte]) {`
`47`		`- lazy val blobId = ObjectFormatter.idFor(OBJ_BLOB, bytes)`
	`45`	`+ lazy val blobId = (new Formatter).idFor(OBJ_BLOB, bytes)`
`48`	`46`	`}`
`49`	`47`
`50`	`48`	`def storeBlob(bytes: Array[Byte])(implicit i: ObjectInserter): ObjectId = i.insert(OBJ_BLOB, bytes)`