Merge pull request #176 from carlosmn/cmn/clippy-run

Clean up some lints

Author: ruabmbua

examples/co2mon.rs

@@ -45,7 +45,7 @@ fn decrypt(buf: Packet) -> Packet {
 
     let magic_word = b"Htemp99e";
     for i in 0..PACKET_SIZE {
-        let sub_val: u8 = (magic_word[i] << 4) | (magic_word[i] >> 4);
+        let sub_val: u8 = magic_word[i].rotate_right(4);
         res[i] = u8::wrapping_sub(res[i], sub_val);
     }
 

examples/dump_descriptors.rs

@@ -8,10 +8,7 @@ fn main() {
             for device in api.device_list() {
                 println!(
                     "  {} (Interface {}):",
-                    match device.product_string() {
-                        Some(s) => s,
-                        _ => "<COULD NOT FETCH>",
-                    },
+                    device.product_string().unwrap_or("<COULD NOT FETCH>"),
                     device.interface_number()
                 );
                 let mut descriptor = vec![0u8; 2048];

examples/lshid.rs

@@ -20,14 +20,8 @@ fn main() {
                     "VID: {:04x}, PID: {:04x}, Serial: {}, Product name: {}, Interface: {}",
                     device.vendor_id(),
                     device.product_id(),
-                    match device.serial_number() {
-                        Some(s) => s,
-                        _ => "<COULD NOT FETCH>",
-                    },
-                    match device.product_string() {
-                        Some(s) => s,
-                        _ => "<COULD NOT FETCH>",
-                    },
+                    device.serial_number().unwrap_or("<COULD NOT FETCH>"),
+                    device.product_string().unwrap_or("<COULD NOT FETCH>"),
                     device.interface_number()
                 );
             }

src/linux_native.rs

@@ -85,29 +85,19 @@ fn device_to_hid_device_info(raw_device: &udev::Device) -> Option<Vec<DeviceInfo
         _ => return None,
     };
 
-    let (bus, vid, pid) = match device
+    let (bus, vid, pid) = device
         .property_value("HID_ID")
         .and_then(|s| s.to_str())
-        .and_then(parse_hid_vid_pid)
-    {
-        Some(t) => t,
-        None => return None,
-    };
+        .and_then(parse_hid_vid_pid)?;
     let bus_type = match bus {
         BUS_USB => BusType::Usb,
         BUS_BLUETOOTH => BusType::Bluetooth,
         BUS_I2C => BusType::I2c,
         BUS_SPI => BusType::Spi,
         _ => return None,
     };
-    let name = match device.property_value("HID_NAME") {
-        Some(name) => name,
-        None => return None,
-    };
-    let serial = match device.property_value("HID_UNIQ") {
-        Some(serial) => serial,
-        None => return None,
-    };
+    let name = device.property_value("HID_NAME")?;
+    let serial = device.property_value("HID_UNIQ")?;
     let path = match raw_device
         .devnode()
         .map(|p| p.as_os_str().to_os_string().into_vec())
@@ -244,10 +234,7 @@ impl<'a> Iterator for UsageIterator<'a> {
     type Item = (u16, u16);
 
     fn next(&mut self) -> Option<Self::Item> {
-        let (usage_page, page) = match next_hid_usage(&mut self.cursor, self.usage_page) {
-            Some(n) => n,
-            None => return None,
-        };
+        let (usage_page, page) = next_hid_usage(&mut self.cursor, self.usage_page)?;
 
         self.usage_page = usage_page;
         Some((usage_page, page))
@@ -267,10 +254,7 @@ fn next_hid_usage(cursor: &mut Cursor<&Vec<u8>>, mut usage_page: u16) -> Option<
         let position = cursor.position() - 1;
         let key_cmd = key & 0xfc;
 
-        let (data_len, key_size) = match hid_item_size(key, cursor) {
-            Some(v) => v,
-            None => return None,
-        };
+        let (data_len, key_size) = hid_item_size(key, cursor)?;
 
         match key_cmd {
             // Usage Page 6.2.2.7 (Global)
@@ -468,7 +452,7 @@ impl HidDevice {
         })
     }
 
-    fn info(&self) -> HidResult<Ref<DeviceInfo>> {
+    fn info(&self) -> HidResult<Ref<'_, DeviceInfo>> {
         if self.info.borrow().is_none() {
             let info = self.get_device_info()?;
             self.info.replace(Some(info));
@@ -480,7 +464,7 @@ impl HidDevice {
 }
 
 impl AsFd for HidDevice {
-    fn as_fd(&self) -> BorrowedFd {
+    fn as_fd(&self) -> BorrowedFd<'_> {
         self.fd.as_fd()
     }
 }