Verify if baseline is outdated

Author: rubensousa

projectguard/src/main/kotlin/com/rubensousa/projectguard/plugin/internal/SuppressionMap.kt

@@ -31,6 +31,20 @@ internal class SuppressionMap {
         }
     }
 
+    fun isOutdated(graph: DependencyGraph): Boolean {
+        suppressions.forEach { (module, suppressions) ->
+            val graphDependencies = graph.getDependencies(module)
+                .associateBy { dependency -> dependency.id }
+                .keys
+            suppressions.forEach { (dependency, _) ->
+                if (!graphDependencies.contains(dependency)) {
+                    return true
+                }
+            }
+        }
+        return false
+    }
+
     fun add(module: String, dependency: String, reason: String = UNSPECIFIED_REASON) {
         add(module, DependencySuppression(dependency, reason))
     }

projectguard/src/main/kotlin/com/rubensousa/projectguard/plugin/internal/task/TaskCheck.kt

@@ -17,6 +17,7 @@
 package com.rubensousa.projectguard.plugin.internal.task
 
 import com.rubensousa.projectguard.plugin.internal.BaselineConfiguration
+import com.rubensousa.projectguard.plugin.internal.DependencyGraphBuilder
 import com.rubensousa.projectguard.plugin.internal.ReportSpec
 import com.rubensousa.projectguard.plugin.internal.SuppressionMap
 import com.rubensousa.projectguard.plugin.internal.YamlProcessor
@@ -84,6 +85,7 @@ internal class CheckExecutor(
 
     fun execute(): Result<Unit> = runCatching {
         val dependencyGraphDump = Json.decodeFromString<DependencyGraphDump>(dependenciesFile.readText())
+        val graph = DependencyGraphBuilder().buildFromDump(dependencyGraphDump)
         val yamlProcessor = YamlProcessor()
         val suppressionMap = SuppressionMap()
         runCatching {
@@ -93,6 +95,12 @@ internal class CheckExecutor(
         }.onFailure {
             println("Skipping baseline since it could not be found or was improperly structured!")
         }
+        if (suppressionMap.isOutdated(graph)) {
+            throw VerificationException(
+                "Baseline contains dependencies that are no longer relevant, " +
+                        "you need to update it with the task projectGuardBaseline"
+            )
+        }
         val restrictionDump = Json.decodeFromString<RestrictionDump>(restrictionDumpFile.readText())
         val reportBuilder = VerificationReportBuilder(suppressionMap, reportSpec)
         val report = reportBuilder.build(dependencyGraphDump, restrictionDump)

projectguard/src/test/kotlin/com/rubensousa/projectguard/plugin/internal/SuppressionMapTest.kt

@@ -22,6 +22,7 @@ import org.junit.Test
 class SuppressionMapTest {
 
     private val suppressionMap = SuppressionMap()
+    private val dependencyGraph = DependencyGraph()
 
     @Test
     fun `getSuppression returns null if dependency is not suppressed`() {
@@ -117,4 +118,34 @@ class SuppressionMapTest {
         assertThat(newLibSuppression?.reason).isEqualTo("AnotherReason")
     }
 
+    @Test
+    fun `isOutdated returns false for empty suppressions`() {
+        // given
+        dependencyGraph.addInternalDependency(module = ":domain", dependency = ":legacy")
+
+        // then
+        assertThat(suppressionMap.isOutdated(dependencyGraph)).isFalse()
+    }
+
+    @Test
+    fun `isOutdated returns false for dependencies that still exist`() {
+        // given
+        dependencyGraph.addInternalDependency(module = ":domain", dependency = ":legacy")
+
+        // when
+        suppressionMap.add(module = ":domain", dependency = ":legacy")
+
+        // then
+        assertThat(suppressionMap.isOutdated(dependencyGraph)).isFalse()
+    }
+
+    @Test
+    fun `isOutdated returns true for dependencies that no longer exist`() {
+        // given
+        suppressionMap.add(module = ":domain", dependency = ":legacy")
+
+        // then
+        assertThat(suppressionMap.isOutdated(dependencyGraph)).isTrue()
+    }
+
 }