Merge pull request #60 from rubocop/fix/57

Change to default `EnforcedStyle: have_no` for `Capybara/NegationMatcher` cop

Author: ydah

CHANGELOG.md

@@ -6,6 +6,7 @@
 - Fix a false negative for `RSpec/HaveSelector` when first argument is dstr node. ([@ydah])
 - Add new `Capybara/RedundantWithinFind` cop. ([@ydah])
 - Fix an invalid attributes parse when name with multiple `[]` for `Capybara/SpecificFinders` and `Capybara/SpecificActions` and `Capybara/SpecificMatcher`. ([@ydah])
+- Change to default `EnforcedStyle: have_no` for `Capybara/NegationMatcher` cop. ([@ydah])
 
 ## 2.19.0 (2023-09-20)
 

config/default.yml

@@ -37,7 +37,8 @@ Capybara/NegationMatcher:
   Description: Enforces use of `have_no_*` or `not_to` for negated expectations.
   Enabled: pending
   VersionAdded: '2.14'
-  EnforcedStyle: not_to
+  VersionChanged: "<<next>>"
+  EnforcedStyle: have_no
   SupportedStyles:
     - have_no
     - not_to

docs/modules/ROOT/pages/cops_capybara.adoc

@@ -170,37 +170,37 @@ expect(page).to match_style(display: 'block')
 | Yes
 | Yes
 | 2.14
-| -
+| <<next>>
 |===
 
 Enforces use of `have_no_*` or `not_to` for negated expectations.
 
 === Examples
 
-==== EnforcedStyle: not_to (default)
+==== EnforcedStyle: have_no (default)
 
 [source,ruby]
 ----
 # bad
-expect(page).to have_no_selector
-expect(page).to have_no_css('a')
-
-# good
 expect(page).not_to have_selector
 expect(page).not_to have_css('a')
+
+# good
+expect(page).to have_no_selector
+expect(page).to have_no_css('a')
 ----
 
-==== EnforcedStyle: have_no
+==== EnforcedStyle: not_to
 
 [source,ruby]
 ----
 # bad
-expect(page).not_to have_selector
-expect(page).not_to have_css('a')
-
-# good
 expect(page).to have_no_selector
 expect(page).to have_no_css('a')
+
+# good
+expect(page).not_to have_selector
+expect(page).not_to have_css('a')
 ----
 
 === Configurable attributes
@@ -209,7 +209,7 @@ expect(page).to have_no_css('a')
 | Name | Default value | Configurable values
 
 | EnforcedStyle
-| `not_to`
+| `have_no`
 | `have_no`, `not_to`
 |===
 

lib/rubocop/cop/capybara/negation_matcher.rb

@@ -5,16 +5,7 @@ module Cop
     module Capybara
       # Enforces use of `have_no_*` or `not_to` for negated expectations.
       #
-      # @example EnforcedStyle: not_to (default)
-      #   # bad
-      #   expect(page).to have_no_selector
-      #   expect(page).to have_no_css('a')
-      #
-      #   # good
-      #   expect(page).not_to have_selector
-      #   expect(page).not_to have_css('a')
-      #
-      # @example EnforcedStyle: have_no
+      # @example EnforcedStyle: have_no (default)
       #   # bad
       #   expect(page).not_to have_selector
       #   expect(page).not_to have_css('a')
@@ -23,6 +14,15 @@ module Capybara
       #   expect(page).to have_no_selector
       #   expect(page).to have_no_css('a')
       #
+      # @example EnforcedStyle: not_to
+      #   # bad
+      #   expect(page).to have_no_selector
+      #   expect(page).to have_no_css('a')
+      #
+      #   # good
+      #   expect(page).not_to have_selector
+      #   expect(page).not_to have_css('a')
+      #
       class NegationMatcher < ::RuboCop::Cop::Base
         extend AutoCorrector
         include ConfigurableEnforcedStyle