Skip to content

Commit 4e2ab24

Browse files
committed
Make Rails/StrongParametersExpect allow presence
This was an oversight in #1583. Since it has not been released yet, there is no changelog entry.
1 parent af61bd0 commit 4e2ab24

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

lib/rubocop/cop/rails/strong_parameters_expect.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class StrongParametersExpect < Base
5353

5454
MSG = 'Use `%<prefer>s` instead.'
5555
RESTRICT_ON_SEND = %i[[] require permit].freeze
56-
PRESENCE_CHECK_METHODS = %i[nil? blank? present?].freeze
56+
PRESENCE_CHECK_METHODS = %i[nil? blank? present? presence].freeze
5757
RAISING_FINDER_METHODS = %i[find find_by! find_sole_by].freeze
5858

5959
minimum_target_rails_version 8.0

spec/rubocop/cop/rails/strong_parameters_expect_spec.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,12 @@
4343
RUBY
4444
end
4545

46+
it 'does not register an offense when using `params[:key].presence`' do
47+
expect_no_offenses(<<~RUBY)
48+
params[:key].presence || default
49+
RUBY
50+
end
51+
4652
it 'registers an offense when using `Model.find(params[:id])`' do
4753
expect_offense(<<~RUBY)
4854
Model.find(params[:id])

0 commit comments

Comments
 (0)