Merge pull request #1061 from koic/fix_a_false_positive_for_rails_http_status

[Fix #1060] Fix a false positive for `Rails/HttpStatus`

Author: koic

changelog/fix_a_false_positive_for_rails_http_status.md

@@ -0,0 +1 @@
+* [#1060](https://github.com/rubocop/rubocop-rails/issues/1060): Fix a false positive for `Rails/HttpStatus` when using symbolic value that have no numeric value mapping. ([@koic][])

lib/rubocop/cop/rails/http_status.rb

@@ -133,7 +133,7 @@ def initialize(node)
           end
 
           def offensive?
-            !node.int_type? && !permitted_symbol?
+            !node.int_type? && !permitted_symbol? && number
           end
 
           def message

spec/rubocop/cop/rails/http_status_spec.rb

@@ -125,5 +125,11 @@
         render :foo, status: :redirect
       RUBY
     end
+
+    it 'does not register an offense when using symbolic value that have no numeric value mapping' do
+      expect_no_offenses(<<~RUBY)
+        render json: { foo: 'bar' }, status: :ng
+      RUBY
+    end
   end
 end