Merge pull request #720 from koic/fix_a_false_negative_for_rails_to_formatted_s

[Fix #719] Fix a false negative for `Rails/FormattedS`

Author: koic

changelog/fix_a_false_negative_for_rails_to_formatted_s.md

@@ -0,0 +1 @@
+* [#719](https://github.com/rubocop/rubocop-rails/issues/719): Fix a false negative for `Rails/FormattedS` when using safe navigation operator. ([@fatkodima][])

lib/rubocop/cop/rails/to_formatted_s.rb

@@ -39,6 +39,7 @@ def on_send(node)
             corrector.replace(node.loc.selector, style)
           end
         end
+        alias on_csend on_send
       end
     end
   end

spec/rubocop/cop/rails/to_formatted_s_spec.rb

@@ -16,6 +16,17 @@
         RUBY
       end
 
+      it 'registers and corrects an offense when using `to_formatted_s` with safe navigation operator' do
+        expect_offense(<<~RUBY)
+          time&.to_formatted_s(:db)
+                ^^^^^^^^^^^^^^ Use `to_fs` instead.
+        RUBY
+
+        expect_correction(<<~RUBY)
+          time&.to_fs(:db)
+        RUBY
+      end
+
       it 'does not register an offense when using `to_fs`' do
         expect_no_offenses(<<~RUBY)
           time.to_fs(:db)
@@ -37,6 +48,17 @@
         RUBY
       end
 
+      it 'registers and corrects an offense when using `to_fs` with safe navigation operator' do
+        expect_offense(<<~RUBY)
+          time&.to_fs(:db)
+                ^^^^^ Use `to_formatted_s` instead.
+        RUBY
+
+        expect_correction(<<~RUBY)
+          time&.to_formatted_s(:db)
+        RUBY
+      end
+
       it 'does not register an offense when using `to_formatted_s`' do
         expect_no_offenses(<<~RUBY)
           time.to_formatted_s(:db)