Merge pull request #1509 from Earlopain/transaction-exit-method-chain

[Fix #1508] Fix an error for `Rails/TransactionExitStatement` when method is chained

Author: koic

changelog/fix_error_transaction_exit.md

@@ -0,0 +1 @@
+* [#1508](https://github.com/rubocop/rubocop-rails/issues/1508): Fix an error for `Rails/TransactionExitStatement` when `transaction` is part of a method chain. ([@earlopain][])

lib/rubocop/cop/rails/transaction_exit_statement.rb

@@ -97,7 +97,8 @@ def on_send(node)
 
         def in_transaction_block?(node)
           return false unless transaction_method_name?(node.method_name)
-          return false unless node.parent&.body
+          return false unless (parent = node.parent)
+          return false unless parent.any_block_type? && parent.body
 
           node.right_siblings.none? do |sibling|
             sibling.respond_to?(:loop_keyword?) && sibling.loop_keyword?

spec/rubocop/cop/rails/transaction_exit_statement_spec.rb

@@ -189,6 +189,18 @@
         end
       RUBY
     end
+
+    it 'does not register an offense when a method call is chained' do
+      expect_no_offenses(<<~RUBY)
+        #{method}.foo
+      RUBY
+    end
+
+    it 'does not register an offense when no receiver and no block' do
+      expect_no_offenses(<<~RUBY)
+        #{method}
+      RUBY
+    end
   end
 
   it_behaves_like 'flags transaction exit statements', :transaction