Merge pull request #616 from TonyArra/unsafe-redundant-presence

[Fix #615] Change Rails/RedundantPresenceValidationOnBelongsTo to SafeAutoCorrect: false

Author: koic

changelog/change_mark_redundant_presence_validation_on_belongs_to_as_unsafe_autocorrect.md

@@ -0,0 +1 @@
+* [#615](https://github.com/rubocop/rubocop-rails/issues/615): Change `Rails/RedundantPresenceValidationOnBelongsTo` to `SafeAutoCorrect: false`. ([@TonyArra][])

config/default.yml

@@ -627,7 +627,9 @@ Rails/RedundantForeignKey:
 Rails/RedundantPresenceValidationOnBelongsTo:
   Description: 'Checks for redundant presence validation on belongs_to association.'
   Enabled: pending
+  SafeAutoCorrect: false
   VersionAdded: '2.13'
+  VersionChanged: '<<next>>'
 
 Rails/RedundantReceiverInWithOptions:
   Description: 'Checks for redundant receiver in `with_options`.'

docs/modules/ROOT/pages/cops_rails.adoc

@@ -3572,7 +3572,7 @@ end
 
 | Pending
 | Yes
-| Yes
+| Yes (Unsafe)
 | 2.13
 | -
 |===

lib/rubocop/cop/rails/redundant_presence_validation_on_belongs_to.rb

@@ -8,6 +8,10 @@ module Rails
       # explicitly set to `false`. The presence validator is added
       # automatically, and explicit presence validation is redundant.
       #
+      # @safety
+      #   This cop's autocorrection is unsafe because it changes the default error message
+      #   from "can't be blank" to "must exist".
+      #
       # @example
       #   # bad
       #   belongs_to :user