Merge pull request #185 from hanachin/allow_task_with_no_block

[Fix #184] Fix Rake/Environment to allow task with no block

Author: koic

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bug fixes
+
+* [#184](https://github.com/rubocop-hq/rubocop-rails/issues/184): Fix `Rake/Environment` to allow task with no block. ([@hanachin][])
+
 ## 2.4.1 (2019-12-25)
 
 ### Bug fixes
@@ -122,3 +126,4 @@
 [@ngouy]: https://github.com/ngouy
 [@mvz]: https://github.com/mvz
 [@fidalgo]: https://github.com/fidalgo
+[@hanachin]: https://github.com/hanachin

lib/rubocop/cop/rails/rake_environment.rb

@@ -29,15 +29,16 @@ class RakeEnvironment < Cop
         MSG = 'Include `:environment` task as a dependency for all Rake tasks.'
 
         def_node_matcher :task_definition?, <<~PATTERN
-          (send nil? :task ...)
+          (block $(send nil? :task ...) ...)
         PATTERN
 
-        def on_send(node)
-          return unless task_definition?(node)
-          return if task_name(node) == :default
-          return if with_dependencies?(node)
+        def on_block(node)
+          task_definition?(node) do |task_method|
+            return if task_name(task_method) == :default
+            return if with_dependencies?(task_method)
 
-          add_offense(node)
+            add_offense(task_method)
+          end
         end
 
         private

spec/rubocop/cop/rails/rake_environment_spec.rb

@@ -83,4 +83,10 @@
       task default: :spec
     RUBY
   end
+
+  it 'does not register an offense to task with no block' do
+    expect_no_offenses(<<~RUBY)
+      task(:foo).do_something
+    RUBY
+  end
 end