Merge pull request #1507 from koic/fix_false_negatives_for_rails_pluck

[Fix #1505] Fix false negatives for `Rails/Pluck`

Author: koic

changelog/fix_false_negatives_for_rails_pluck.md

@@ -0,0 +1 @@
+* [#1505](https://github.com/rubocop/rubocop-rails/issues/1505): Fix false negatives for `Rails/Pluck` when `map` method call is used in a block without a receiver. ([@koic][])

lib/rubocop/cop/rails/pluck.rb

@@ -27,6 +27,9 @@ module Rails
       # end
       # ----
       #
+      # If a method call has no receiver, like `do_something { users.map { |user| user[:foo] }`,
+      # it is not considered part of an iteration and will be detected.
+      #
       # @safety
       #   This cop is unsafe because model can use column aliases.
       #
@@ -59,9 +62,9 @@ class Pluck < Base
           (any_block (call _ {:map :collect}) $_argument (send lvar :[] $_key))
         PATTERN
 
-        # rubocop:disable Metrics/AbcSize
+        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def on_block(node)
-          return if node.each_ancestor(:any_block).any?
+          return if node.each_ancestor(:any_block).first&.receiver
 
           pluck_candidate?(node) do |argument, key|
             next if key.regexp_type? || !use_one_block_argument?(argument)
@@ -79,7 +82,7 @@ def on_block(node)
             register_offense(node, key)
           end
         end
-        # rubocop:enable Metrics/AbcSize
+        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         alias on_numblock on_block
         alias on_itblock on_block
 

spec/rubocop/cop/rails/pluck_spec.rb

@@ -154,7 +154,24 @@
         end
       end
 
-      context "when `#{method}` is used in block" do
+      context "when `#{method}` is used in a block without a receiver" do
+        it 'registers an offense' do
+          expect_offense(<<~RUBY, method: method)
+            foo do
+              x.%{method} { |a| a[:foo] }
+                ^{method}^^^^^^^^^^^^^^^^ Prefer `pluck(:foo)` over `%{method} { |a| a[:foo] }`.
+            end
+          RUBY
+
+          expect_correction(<<~RUBY)
+            foo do
+              x.pluck(:foo)
+            end
+          RUBY
+        end
+      end
+
+      context "when `#{method}` is used in a repeatable block" do
         it 'does not register an offense' do
           expect_no_offenses(<<~RUBY)
             n.each do |x|
@@ -164,7 +181,7 @@
         end
       end
 
-      context "when `#{method}` is used in block with other operations" do
+      context "when `#{method}` is used in a repeatable block with other operations" do
         it 'does not register an offense' do
           expect_no_offenses(<<~RUBY)
             n.each do |x|
@@ -175,7 +192,7 @@
         end
       end
 
-      context "when `#{method}` is used in numblock" do
+      context "when `#{method}` is used in a repeatable numblock" do
         it 'does not register an offense' do
           expect_no_offenses(<<~RUBY)
             n.each do
@@ -185,7 +202,7 @@
         end
       end
 
-      context "when `#{method}` is used in numblock with other operations" do
+      context "when `#{method}` is used in reapeatable numblock with other operations" do
         it 'does not register an offense' do
           expect_no_offenses(<<~RUBY)
             n.each do