Merge pull request #663 from koic/fix_a_false_positive_for_rails_migration_class_name

[Fix #660] Fix a false positive for `Rails/MigrationClassName`

Author: koic

changelog/fix_a_false_positive_for_rails_migration_class_name.md

@@ -0,0 +1 @@
+* [#660](https://github.com/rubocop/rubocop-rails/issues/660): Fix a false positive for `Rails/MigrationClassName` when defining another class. ([@koic][])

lib/rubocop/cop/rails/migration_class_name.rb

@@ -25,7 +25,7 @@ class MigrationClassName < Base
         MSG = 'Replace with `%<corrected_class_name>s` that matches the file name.'
 
         def on_class(node)
-          return if in_migration?(node)
+          return unless migration_class?(node)
 
           snake_class_name = to_snakecase(node.identifier.source)
 

spec/rubocop/cop/rails/migration_class_name_spec.rb

@@ -12,6 +12,18 @@ class CreateUsers < ActiveRecord::Migration[7.0]
     end
 
     context 'when defining another class' do
+      it 'does not register an offense' do
+        expect_no_offenses(<<~RUBY, filename)
+          class Article < ActiveRecord::Base
+          end
+
+          class CreateUsers < ActiveRecord::Migration[7.0]
+          end
+        RUBY
+      end
+    end
+
+    context 'when defining an inner class' do
       it 'does not register an offense' do
         expect_no_offenses(<<~RUBY, filename)
           class CreateUsers < ActiveRecord::Migration[7.0]