Skip to content

Commit b2b0e1b

Browse files
authored
Merge pull request #580 from koic/change_unmark_autocorrect_false_from_rails_uniq_before_pluck
Unmark `AutoCorrect: false` from `Rails/UniqBeforePluck`
2 parents 9e4bfa3 + 8434627 commit b2b0e1b

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
* [#580](https://github.com/rubocop/rubocop-rails/pull/580): Unmark `AutoCorrect: false` from `Rails/UniqBeforePluck`. ([@koic][])

config/default.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -827,13 +827,12 @@ Rails/UniqBeforePluck:
827827
Description: 'Prefer the use of uniq or distinct before pluck.'
828828
Enabled: true
829829
VersionAdded: '0.40'
830-
VersionChanged: '2.8'
830+
VersionChanged: '2.13'
831831
EnforcedStyle: conservative
832832
SupportedStyles:
833833
- conservative
834834
- aggressive
835835
SafeAutoCorrect: false
836-
AutoCorrect: false
837836

838837
Rails/UniqueValidationWithoutIndex:
839838
Description: 'Uniqueness validation should have a unique index on the database column.'

docs/modules/ROOT/pages/cops_rails.adoc

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4909,7 +4909,7 @@ end
49094909
| Yes
49104910
| Yes (Unsafe)
49114911
| 0.40
4912-
| 2.8
4912+
| 2.13
49134913
|===
49144914

49154915
Prefer the use of distinct, before pluck instead of after.
@@ -4974,10 +4974,6 @@ Model.distinct.pluck(:id)
49744974
| EnforcedStyle
49754975
| `conservative`
49764976
| `conservative`, `aggressive`
4977-
4978-
| AutoCorrect
4979-
| `false`
4980-
| Boolean
49814977
|===
49824978

49834979
== Rails/UniqueValidationWithoutIndex

0 commit comments

Comments
 (0)