Make Rails/SkipsModelValidations aware of safe navigation operator

Author: hoshinotsuyoshi

lib/rubocop/cop/rails/skips_model_validations.rb

@@ -67,6 +67,7 @@ def on_send(node)
 
           add_offense(node, location: :selector)
         end
+        alias on_csend on_send
 
         private
 

spec/rubocop/cop/rails/skips_model_validations_spec.rb

@@ -77,6 +77,15 @@
              ^^^^^^^^^^^^^^^^ Avoid using `update_attribute` because it skips validations.
       RUBY
     end
+
+    context 'when using safe navigation operator', :ruby23 do
+      it 'registers an offense for `update_attribute`' do
+        expect_offense(<<-RUBY.strip_indent)
+        user&.update_attribute(:website, 'example.com')
+              ^^^^^^^^^^^^^^^^ Avoid using `update_attribute` because it skips validations.
+        RUBY
+      end
+    end
   end
 
   context 'with whitelist' do
@@ -94,6 +103,15 @@
       RUBY
     end
 
+    context 'when using safe navigation operator', :ruby23 do
+      it 'registers an offense for method not in whitelist' do
+        expect_offense(<<-RUBY.strip_indent)
+        user&.toggle!(:active)
+              ^^^^^^^ Avoid using `toggle!` because it skips validations.
+        RUBY
+      end
+    end
+
     it 'accepts method in whitelist, superseding the blacklist' do
       expect_no_offenses('User.touch(:attr)')
     end