Merge pull request #606 from TonyArra/reversible-migration-remove-reference

[Fix #604] Remove `remove_reference` checks from `Rails/ReversibleMigration`

Author: koic

CHANGELOG.md

@@ -503,3 +503,4 @@
 [@vitormd]: https://github.com/vitormd
 [@mattmccormick]: https://github.com/mattmccormick
 [@leoarnold]: https://github.com/leoarnold
+[@TonyArra]: https://github.com/TonyArra

changelog/change_remove_remove_reference_checks_from.md

@@ -0,0 +1 @@
+* [#604](https://github.com/rubocop/rubocop-rails/issues/604): Remove `remove_reference` and `remove_belongs_to` methods from `Rails/ReversibleMigration` cop offenses. ([@TonyArra][])

lib/rubocop/cop/rails/reversible_migration.rb

@@ -179,7 +179,7 @@ class ReversibleMigration < Base
         MSG = '%<action>s is not reversible.'
 
         def_node_matcher :irreversible_schema_statement_call, <<~PATTERN
-          (send nil? ${:change_column :execute :remove_belongs_to :remove_reference} ...)
+          (send nil? ${:change_column :execute} ...)
         PATTERN
 
         def_node_matcher :drop_table_call, <<~PATTERN

spec/rubocop/cop/rails/reversible_migration_spec.rb

@@ -171,20 +171,6 @@ def change
     RUBY
   end
 
-  context 'remove_belongs_to' do
-    it_behaves_like 'accepts', 'up_only', <<~RUBY
-      up_only { remove_belongs_to(:products, :user, index: false) }
-    RUBY
-
-    it_behaves_like 'offense', 'remove_belongs_to', <<~RUBY
-      remove_belongs_to(:products, :user, index: false)
-    RUBY
-
-    it_behaves_like 'offense', 'remove_belongs_to', <<~RUBY
-      remove_belongs_to(:products, :supplier, polymorphic: true)
-    RUBY
-  end
-
   context 'remove_column' do
     it_behaves_like 'accepts', 'remove_column(with type)', <<~RUBY
       remove_column(:suppliers, :qualification, :string)
@@ -213,20 +199,6 @@ def change
     RUBY
   end
 
-  context 'remove_reference' do
-    it_behaves_like 'accepts', 'up_only', <<~RUBY
-      up_only { remove_reference(:products, :user, index: false) }
-    RUBY
-
-    it_behaves_like 'offense', 'remove_reference', <<~RUBY
-      remove_reference(:products, :user, index: false)
-    RUBY
-
-    it_behaves_like 'offense', 'remove_reference', <<~RUBY
-      remove_reference(:products, :supplier, polymorphic: true)
-    RUBY
-  end
-
   context 'change_table' do
     it_behaves_like 'accepts', 'change_table(with reversible calls)', <<~RUBY
       change_table :users do |t|