Skip to content

Commit e0bfc5e

Browse files
authored
Merge pull request #109 from koic/fix_a_style_guild_url
[Fix #107] Fix style guide URLs
2 parents e551c9b + 0092e77 commit e0bfc5e

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
### Bug fixes
66

77
* [#104](https://github.com/rubocop-hq/rubocop-rails/issues/104): Exclude Rails-independent `bin/bundle` by default. ([@koic][])
8+
* [#107](https://github.com/rubocop-hq/rubocop-rails/issues/107): Fix style guide URLs when specifying `rubocop --display-style-guide` option. ([@koic][])
89

910
## 2.3.0 (2019-08-13)
1011

config/default.yml

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ AllCops:
1111
# application. If neither of those files exist, RuboCop will use Rails 5.0
1212
# as the default.
1313
TargetRailsVersion: ~
14-
# When specifying style guide URLs, any paths and/or fragments will be
15-
# evaluated relative to the base URL.
16-
StyleGuideBaseURL: https://rails.rubystyle.guide
1714

1815
Rails/ActionFilter:
1916
Description: 'Enforces consistent use of action filter methods.'
@@ -142,15 +139,15 @@ Rails/DelegateAllowBlank:
142139

143140
Rails/DynamicFindBy:
144141
Description: 'Use `find_by` instead of dynamic `find_by_*`.'
145-
StyleGuide: '#find_by'
142+
StyleGuide: 'https://rails.rubystyle.guide#find_by'
146143
Enabled: true
147144
VersionAdded: '0.44'
148145
Whitelist:
149146
- find_by_sql
150147

151148
Rails/EnumHash:
152149
Description: 'Prefer hash syntax over array syntax when defining enums.'
153-
StyleGuide: '#enums'
150+
StyleGuide: 'https://rails.rubystyle.guide#enums'
154151
Enabled: true
155152
VersionAdded: '2.3'
156153
Include:
@@ -194,31 +191,31 @@ Rails/FilePath:
194191

195192
Rails/FindBy:
196193
Description: 'Prefer find_by over where.first.'
197-
StyleGuide: '#find_by'
194+
StyleGuide: 'https://rails.rubystyle.guide#find_by'
198195
Enabled: true
199196
VersionAdded: '0.30'
200197
Include:
201198
- app/models/**/*.rb
202199

203200
Rails/FindEach:
204201
Description: 'Prefer all.find_each over all.find.'
205-
StyleGuide: '#find-each'
202+
StyleGuide: 'https://rails.rubystyle.guide#find-each'
206203
Enabled: true
207204
VersionAdded: '0.30'
208205
Include:
209206
- app/models/**/*.rb
210207

211208
Rails/HasAndBelongsToMany:
212209
Description: 'Prefer has_many :through to has_and_belongs_to_many.'
213-
StyleGuide: '#has-many-through'
210+
StyleGuide: 'https://rails.rubystyle.guide#has-many-through'
214211
Enabled: true
215212
VersionAdded: '0.12'
216213
Include:
217214
- app/models/**/*.rb
218215

219216
Rails/HasManyOrHasOneDependent:
220217
Description: 'Define the dependent option to the has_many and has_one associations.'
221-
StyleGuide: '#has_many-has_one-dependent-option'
218+
StyleGuide: 'https://rails.rubystyle.guide#has_many-has_one-dependent-option'
222219
Enabled: true
223220
VersionAdded: '0.50'
224221
Include:
@@ -265,7 +262,7 @@ Rails/InverseOf:
265262

266263
Rails/LexicallyScopedActionFilter:
267264
Description: "Checks that methods specified in the filter's `only` or `except` options are explicitly defined in the controller."
268-
StyleGuide: '#lexically-scoped-action-filter'
265+
StyleGuide: 'https://rails.rubystyle.guide#lexically-scoped-action-filter'
269266
Enabled: true
270267
Safe: false
271268
VersionAdded: '0.52'
@@ -330,7 +327,7 @@ Rails/ReadWriteAttribute:
330327
Description: >-
331328
Checks for read_attribute(:attr) and
332329
write_attribute(:attr, val).
333-
StyleGuide: '#read-attribute'
330+
StyleGuide: 'https://rails.rubystyle.guide#read-attribute'
334331
Enabled: true
335332
VersionAdded: '0.20'
336333
VersionChanged: '0.29'
@@ -381,7 +378,7 @@ Rails/RequestReferer:
381378

382379
Rails/ReversibleMigration:
383380
Description: 'Checks whether the change method of the migration file is reversible.'
384-
StyleGuide: '#reversible-migration'
381+
StyleGuide: 'https://rails.rubystyle.guide#reversible-migration'
385382
Reference: 'https://api.rubyonrails.org/classes/ActiveRecord/Migration/CommandRecorder.html'
386383
Enabled: true
387384
VersionAdded: '0.47'
@@ -400,7 +397,7 @@ Rails/SafeNavigation:
400397

401398
Rails/SaveBang:
402399
Description: 'Identifies possible cases where Active Record save! or related should be used.'
403-
StyleGuide: '#save-bang'
400+
StyleGuide: 'https://rails.rubystyle.guide#save-bang'
404401
Enabled: false
405402
VersionAdded: '0.42'
406403
VersionChanged: '0.59'
@@ -439,7 +436,7 @@ Rails/SkipsModelValidations:
439436

440437
Rails/TimeZone:
441438
Description: 'Checks the correct usage of time zone aware methods.'
442-
StyleGuide: '#time'
439+
StyleGuide: 'https://rails.rubystyle.guide#time'
443440
Reference: 'http://danilenko.org/2012/7/6/rails_timezones'
444441
Enabled: true
445442
Safe: false

0 commit comments

Comments
 (0)