Merge pull request #1013 from fatkodima/fix-three_state_boolean-dynamic-table

Fix `Rails/ThreeStateBooleanColumn` for dynamic tables/columns

Author: koic

changelog/fix_three_state_boolean_column_for_dynamic_values.md

@@ -0,0 +1 @@
+* [#1010](https://github.com/rubocop/rubocop-rails/issues/1010): Fix `Rails/ThreeStateBooleanColumn` for dynamic tables/columns. ([@fatkodima][])

lib/rubocop/cop/rails/three_state_boolean_column.rb

@@ -35,7 +35,7 @@ class ThreeStateBooleanColumn < Base
         PATTERN
 
         def_node_search :change_column_null?, <<~PATTERN
-          (send nil? :change_column_null {(sym %1) (str %1)} {(sym %2) (str %2)} false)
+          (send nil? :change_column_null %1 %2 false)
         PATTERN
 
         def on_send(node)
@@ -46,9 +46,7 @@ def on_send(node)
 
             def_node = node.each_ancestor(:def, :defs).first
             table_node = table_node(node)
-            if def_node && (table_node.nil? || change_column_null?(def_node, table_node.value, column_node.value))
-              return
-            end
+            return if def_node && (table_node.nil? || change_column_null?(def_node, table_node, column_node))
 
             add_offense(node)
           end

spec/rubocop/cop/rails/three_state_boolean_column_spec.rb

@@ -34,6 +34,15 @@ def change
       RUBY
     end
 
+    it 'does not register an offense when using `#change_column_null` with dynamic table' do
+      expect_no_offenses(<<~RUBY)
+        def change
+          add_column table, :active, :boolean
+          change_column_null table, :active, false
+        end
+      RUBY
+    end
+
     it 'registers an offense when using `#change_column_null` for other table or column' do
       expect_offense(<<~RUBY)
         def change
@@ -82,6 +91,17 @@ def change
       RUBY
     end
 
+    it 'does not register an offense when using `#change_column_null` with dynamic table' do
+      expect_no_offenses(<<~RUBY)
+        def change
+          create_table(table) do |t|
+            t.column :active, :boolean
+          end
+          change_column_null table, :active, false
+        end
+      RUBY
+    end
+
     it 'registers an offense when using `#change_column_null` for other table or column' do
       expect_offense(<<~RUBY)
         def change
@@ -136,6 +156,17 @@ def change
       RUBY
     end
 
+    it 'does not register an offense when using `#change_column_null` with dynamic table' do
+      expect_no_offenses(<<~RUBY)
+        def change
+          create_table(table) do |t|
+            t.boolean :active
+          end
+          change_column_null table, :active, false
+        end
+      RUBY
+    end
+
     it 'registers an offense when using `#change_column_null` for other table or column' do
       expect_offense(<<~RUBY)
         def change