Cut 2.34.0

Author: koic

CHANGELOG.md

@@ -9,6 +9,8 @@
 
 ## master (unreleased)
 
+## 2.34.0 (2025-11-16)
+
 ### New features
 
 * [#1520](https://github.com/rubocop/rubocop-rails/pull/1520): New `Rails/HttpStatusNameConsistency` cop. ([@tuxagon][])

config/default.yml

@@ -471,7 +471,7 @@ Rails/EnumUniqueness:
 Rails/Env:
   Description: 'Use Feature Flags or config instead of `Rails.env`.'
   Enabled: false
-  VersionAdded: '<<next>>'
+  VersionAdded: '2.34'
 
 Rails/EnvLocal:
   Description: 'Use `Rails.env.local?` instead of `Rails.env.development? || Rails.env.test?`.'
@@ -618,7 +618,7 @@ Rails/HttpStatusNameConsistency:
   Description: 'Enforces consistency by using the current HTTP status names.'
   Enabled: pending
   Severity: warning
-  VersionAdded: '<<next>>'
+  VersionAdded: '2.34'
   Include:
     - '**/app/controllers/**/*.rb'
 
@@ -844,7 +844,7 @@ Rails/Presence:
   Description: 'Checks code that can be written more easily using `Object#presence` defined by Active Support.'
   Enabled: true
   VersionAdded: '0.52'
-  VersionChanged: '<<next>>'
+  VersionChanged: '2.34'
 
 Rails/Present:
   Description: 'Enforces use of `present?`.'
@@ -887,7 +887,7 @@ Rails/RedirectBackOrTo:
                   `fallback_location` option.
   Enabled: pending
   Severity: warning
-  VersionAdded: '<<next>>'
+  VersionAdded: '2.34'
 
 Rails/RedundantActiveRecordAllMethod:
   Description: Detect redundant `all` used as a receiver for Active Record query methods.

docs/antora.yml

@@ -2,6 +2,6 @@ name: rubocop-rails
 title: RuboCop Rails
 # We always provide version without patch here (e.g. 1.1),
 # as patch versions should not appear in the docs.
-version: ~
+version: '2.34'
 nav:
   - modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops.adoc

@@ -55,6 +55,7 @@ based on the https://rails.rubystyle.guide/[Rails Style Guide].
 * xref:cops_rails.adoc#railsenumhash[Rails/EnumHash]
 * xref:cops_rails.adoc#railsenumsyntax[Rails/EnumSyntax]
 * xref:cops_rails.adoc#railsenumuniqueness[Rails/EnumUniqueness]
+* xref:cops_rails.adoc#railsenv[Rails/Env]
 * xref:cops_rails.adoc#railsenvlocal[Rails/EnvLocal]
 * xref:cops_rails.adoc#railsenvironmentcomparison[Rails/EnvironmentComparison]
 * xref:cops_rails.adoc#railsenvironmentvariableaccess[Rails/EnvironmentVariableAccess]
@@ -71,6 +72,7 @@ based on the https://rails.rubystyle.guide/[Rails Style Guide].
 * xref:cops_rails.adoc#railshelperinstancevariable[Rails/HelperInstanceVariable]
 * xref:cops_rails.adoc#railshttppositionalarguments[Rails/HttpPositionalArguments]
 * xref:cops_rails.adoc#railshttpstatus[Rails/HttpStatus]
+* xref:cops_rails.adoc#railshttpstatusnameconsistency[Rails/HttpStatusNameConsistency]
 * xref:cops_rails.adoc#railsi18nlazylookup[Rails/I18nLazyLookup]
 * xref:cops_rails.adoc#railsi18nlocaleassignment[Rails/I18nLocaleAssignment]
 * xref:cops_rails.adoc#railsi18nlocaletexts[Rails/I18nLocaleTexts]
@@ -101,6 +103,7 @@ based on the https://rails.rubystyle.guide/[Rails Style Guide].
 * xref:cops_rails.adoc#railspresent[Rails/Present]
 * xref:cops_rails.adoc#railsrakeenvironment[Rails/RakeEnvironment]
 * xref:cops_rails.adoc#railsreadwriteattribute[Rails/ReadWriteAttribute]
+* xref:cops_rails.adoc#railsredirectbackorto[Rails/RedirectBackOrTo]
 * xref:cops_rails.adoc#railsredundantactiverecordallmethod[Rails/RedundantActiveRecordAllMethod]
 * xref:cops_rails.adoc#railsredundantallownil[Rails/RedundantAllowNil]
 * xref:cops_rails.adoc#railsredundantforeignkey[Rails/RedundantForeignKey]

docs/modules/ROOT/pages/cops_rails.adoc

@@ -1827,7 +1827,7 @@ has_one :foo
 | 2.18
 |===
 
-Checks for multiple scopes in a model that have the same `where` clause. This
+Checks for multiple scopes in a model that have the same expression. This
 often means you copy/pasted a scope, updated the name, and forgot to change the condition.
 
 [#examples-railsduplicatescope]
@@ -2184,6 +2184,35 @@ enum status: [:active, :archived]
 | Array
 |===
 
+[#railsenv]
+== Rails/Env
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Disabled
+| Yes
+| No
+| 2.34
+| -
+|===
+
+Checks for usage of `Rails.env` which can be replaced with Feature Flags
+
+[#examples-railsenv]
+=== Examples
+
+[source,ruby]
+----
+# bad
+Rails.env.production? || Rails.env.local?
+
+# good
+if FeatureFlag.enabled?(:new_feature)
+  # new feature code
+end
+----
+
 [#railsenvlocal]
 == Rails/EnvLocal
 
@@ -2227,7 +2256,7 @@ Rails.env.local?
 | -
 |===
 
-Checks that Rails.env is compared using `.production?`-like
+Checks that `Rails.env` is compared using `.production?`-like
 methods instead of equality against a string or symbol.
 
 [#examples-railsenvironmentcomparison]
@@ -2237,6 +2266,7 @@ methods instead of equality against a string or symbol.
 ----
 # bad
 Rails.env == 'production'
+Rails.env.to_sym == :production
 
 # bad, always returns false
 Rails.env == :test
@@ -2351,7 +2381,7 @@ ENV["FOO"] = "bar"
 | -
 |===
 
-Enforces that `exit` calls are not used within a rails app.
+Enforces that `exit` and `abort` calls are not used within a rails app.
 Valid options are instead to raise an error, break, return, or some
 other form of stopping execution of current request.
 
@@ -2626,6 +2656,9 @@ Avoid memoizing `find_by` results with `||=`.
 It is common to see code that attempts to memoize `find_by` result by `||=`,
 but `find_by` may return `nil`, in which case it is not memoized as intended.
 
+NOTE: Respecting the object shapes introduced in Ruby 3.2, instance variables used
+for memoization that are initialized at object creation are ignored.
+
 [#safety-railsfindbyorassignmentmemoization]
 === Safety
 
@@ -2921,7 +2954,7 @@ If it seems awkward to explicitly pass in each dependent
 variable, consider moving the behavior elsewhere, for
 example to a model, decorator or presenter.
 
-Provided that a class inherits `ActionView::Helpers::FormBuilder`,
+Provided that an instance variable belongs to a class,
 an offense will not be registered.
 
 [#examples-railshelperinstancevariable]
@@ -2940,8 +2973,16 @@ def welcome_message(user)
 end
 
 # good
-class MyFormBuilder < ActionView::Helpers::FormBuilder
-  @template.do_something
+module ButtonHelper
+  class Welcome
+    def initialize(text:)
+      @text = text
+    end
+  end
+
+  def welcome(**)
+    render Welcome.new(**)
+  end
 end
 ----
 
@@ -3083,6 +3124,50 @@ assert_redirected_to '/some/path', status: 301
 | `numeric`, `symbolic`
 |===
 
+[#railshttpstatusnameconsistency]
+== Rails/HttpStatusNameConsistency
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| Yes
+| Always
+| 2.34
+| -
+|===
+
+Enforces consistency by using the current HTTP status names.
+
+[#examples-railshttpstatusnameconsistency]
+=== Examples
+
+[source,ruby]
+----
+# bad
+render json: { error: "Invalid data" }, status: :unprocessable_entity
+head :payload_too_large
+
+# good
+render json: { error: "Invalid data" }, status: :unprocessable_content
+head :content_too_large
+----
+
+[#configurable-attributes-railshttpstatusnameconsistency]
+=== Configurable attributes
+
+|===
+| Name | Default value | Configurable values
+
+| Severity
+| `warning`
+| String
+
+| Include
+| `+**/app/controllers/**/*.rb+`
+| Array
+|===
+
 [#railsi18nlazylookup]
 == Rails/I18nLazyLookup
 
@@ -4716,7 +4801,7 @@ core extensions to the numeric classes.
 | Yes
 | Always
 | 0.52
-| -
+| 2.34
 |===
 
 Checks code that can be written more easily using
@@ -4761,6 +4846,24 @@ a.blank? ? b : a
 a.presence || b
 ----
 
+[source,ruby]
+----
+# bad
+a.present? ? a.foo : nil
+
+# bad
+!a.present? ? nil : a.foo
+
+# bad
+a.blank? ? nil : a.foo
+
+# bad
+!a.blank? ? a.foo : nil
+
+# good
+a.presence&.foo
+----
+
 [#railspresent]
 == Rails/Present
 
@@ -4980,6 +5083,56 @@ end
 
 * https://rails.rubystyle.guide#read-attribute
 
+[#railsredirectbackorto]
+== Rails/RedirectBackOrTo
+
+NOTE: Requires Rails version 7.0
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| Yes
+| Always
+| 2.34
+| -
+|===
+
+Checks for uses of `redirect_back(fallback_location: ...)` and
+suggests using `redirect_back_or_to(...)` instead.
+
+`redirect_back(fallback_location: ...)` was soft deprecated in Rails 7.0 and
+`redirect_back_or_to` was introduced as a replacement.
+
+[#examples-railsredirectbackorto]
+=== Examples
+
+[source,ruby]
+----
+# bad
+redirect_back(fallback_location: root_path)
+
+# good
+redirect_back_or_to(root_path)
+
+# bad
+redirect_back(fallback_location: root_path, allow_other_host: false)
+
+# good
+redirect_back_or_to(root_path, allow_other_host: false)
+----
+
+[#configurable-attributes-railsredirectbackorto]
+=== Configurable attributes
+
+|===
+| Name | Default value | Configurable values
+
+| Severity
+| `warning`
+| String
+|===
+
 [#railsredundantactiverecordallmethod]
 == Rails/RedundantActiveRecordAllMethod
 

lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.33.4'
+      STRING = '2.34.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

relnotes/v2.34.0.md

@@ -0,0 +1,28 @@
+### New features
+
+* [#1520](https://github.com/rubocop/rubocop-rails/pull/1520): New `Rails/HttpStatusNameConsistency` cop. ([@tuxagon][])
+* [#1376](https://github.com/rubocop/rubocop-rails/issues/1376): Add new `Rails/Env` cop. ([@cdudas17][])
+* [#1541](https://github.com/rubocop/rubocop-rails/pull/1541): Add new `Rails/RedirectBackOrTo` cop to suggest using `redirect_back_or_to` instead of `redirect_back` with `fallback_location`. ([@davidenglishmusic][])
+
+### Bug fixes
+
+* [#1539](https://github.com/rubocop/rubocop-rails/issues/1539): Fix an error in `Rails/ActionControllerFlashBeforeRender` when `flash` is used inside a block followed by method chaining. ([@koic][])
+* [#1553](https://github.com/rubocop/rubocop-rails/issues/1553): Fix false positives for `Rails/OutputSafety` when using non-interpolated multiline heredoc. ([@koic][])
+* [#1532](https://github.com/rubocop/rubocop-rails/issues/1532): Fix false positives for `Rails/FindByOrAssignmentMemoization` when assigning a memoization instance variable at `initialize` method. ([@koic][])
+* [#1549](https://github.com/rubocop/rubocop-rails/pull/1549): Fix `Rails/InverseOf` cop false positives when using dynamic association options. ([@viralpraxis][])
+
+### Changes
+
+* [#1537](https://github.com/rubocop/rubocop-rails/pull/1537): Add `abort` to the `Rails/Exit` cop. ([@adamstegman][])
+* [#932](https://github.com/rubocop/rubocop-rails/issues/932): Add support for chained method calls in `Rails/Presence`. ([@vlad-pisanov][])
+* [#1525](https://github.com/rubocop/rubocop-rails/issues/1525): Change `Rails::HelperInstanceVariable` not to detect offenses for instance variables within classes. ([@viralpraxis][])
+* [#1481](https://github.com/rubocop/rubocop-rails/pull/1481): Recognize `Rails.env.to_sym` in `Rails/EnvironmentComparison`. ([@lovro-bikic][])
+
+[@tuxagon]: https://github.com/tuxagon
+[@cdudas17]: https://github.com/cdudas17
+[@davidenglishmusic]: https://github.com/davidenglishmusic
+[@koic]: https://github.com/koic
+[@viralpraxis]: https://github.com/viralpraxis
+[@adamstegman]: https://github.com/adamstegman
+[@vlad-pisanov]: https://github.com/vlad-pisanov
+[@lovro-bikic]: https://github.com/lovro-bikic