Change Rails/HelperInstanceVariable not to detect offenses for ivars within classes
#1538
+25
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viralpraxis
force-pushed
the
change-rails-helper-instance-variable-no-to-detect-ivars-within-classes
branch
from
42b6e84 to
00fe24d
Compare
viralpraxis
changed the title
Rails/HelperInstanceVariable not to detect offenses for ivars within classesRails/HelperInstanceVariable not to detect offenses for ivars within classes
viralpraxis
force-pushed
the
change-rails-helper-instance-variable-no-to-detect-ivars-within-classes
branch
from
00fe24d to
95d9470
Compare
koic
reviewed
Oct 10, 2025
koic
reviewed
Oct 10, 2025
koic
reviewed
Oct 10, 2025
| end | ||
|
|
||
| it 'does not register an offense when a class which inherits `ActionView::Helpers::FormBuilder`' do | ||
| it 'does not register an offense when an instance variable is defined within a class' do |
There was a problem hiding this comment.
Can you add it as a new test instead of updating the existing one?
There was a problem hiding this comment.
I've removed that one since there's nothing specific about ActionView::Helpers::FormBuilder class anymore. Does it make sense to keep it?
There was a problem hiding this comment.
I thought it would be better to keep it as a working example from the past based on the feedback, but it’s not a strong opinion. Your opinion makes sense.
…s within classes Resolves rubocop#1525
viralpraxis
force-pushed
the
change-rails-helper-instance-variable-no-to-detect-ivars-within-classes
branch
from
95d9470 to
cfacd2b
Compare
koic
reviewed
Oct 13, 2025
| end | ||
|
|
||
| false | ||
| def variable_belongs_to_class?(node) |
There was a problem hiding this comment.
Since the term variable is broad, using instance_variable would make it clearer.
Suggested change
| def variable_belongs_to_class?(node) | |
| def instance_variable_belongs_to_class?(node) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1525
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.