Merge pull request #1286 from tejasbubane/fix-1105

Fix incorrect path suggested by `RSpec/FilePath` cop when second argument contains spaces

Author: pirj

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
 ## Master (Unreleased)
+* Fix incorrect path suggested by `RSpec/FilePath` cop when second argument contains spaces. ([@tejasbubane][])
 
 ## 2.11.1 (2022-05-18)
 

lib/rubocop/cop/rspec/file_path.rb

@@ -117,8 +117,9 @@ def pattern_for_spec_suffix_only?
 
         def name_pattern(method_name)
           return unless method_name&.str_type?
+          return if ignore_methods?
 
-          ".*#{method_name.str_content.gsub(/\W/, '')}" unless ignore_methods?
+          ".*#{method_name.str_content.gsub(/\s/, '_').gsub(/\W/, '')}"
         end
 
         def expected_path(constant)

spec/rubocop/cop/rspec/file_path_spec.rb

@@ -57,6 +57,13 @@
     RUBY
   end
 
+  it 'registers an offense when second argument contains spaces' do
+    expect_offense(<<-RUBY, 'wrong_class_spec.rb')
+      describe MyClass, "via `local_failures`" do; end
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Spec path should end with `my_class*via_local_failures*_spec.rb`.
+    RUBY
+  end
+
   it 'registers an offense for a file missing _spec' do
     expect_offense(<<-RUBY, 'spec/models/user.rb')
       describe User do; end