Enable our own pending RSpec cops

How I used Ruby to find the cop names:

    require "yaml"
    puts YAML.load_file("config/default.yml").select { |_name, config|
      config["Enabled"] == "pending"
    }.keys

Author: bquorning

.github/PULL_REQUEST_TEMPLATE.md

@@ -15,6 +15,7 @@ If you have created a new cop:
 
 * [ ] Added the new cop to `config/default.yml`.
 * [ ] The cop is configured as `Enabled: pending` in `config/default.yml`.
+* [ ] The cop is configured as `Enabled: true` in `.rubocop.yml`.
 * [ ] The cop documents examples of good and bad code.
 * [ ] The tests assert both that bad code is reported and that good code is not reported.
 * [ ] Set `VersionAdded` in `default/config.yml` to the next minor version.

.rubocop.yml

@@ -84,3 +84,26 @@ RSpec/DescribeClass:
 Style/FormatStringToken:
   Exclude:
     - spec/rubocop/**/*.rb
+
+# Enable our own pending cops.
+
+RSpec/BeEq:
+  Enabled: true
+RSpec/BeNil:
+  Enabled: true
+RSpec/ChangeByZero:
+  Enabled: true
+RSpec/ExcessiveDocstringSpacing:
+  Enabled: true
+RSpec/IdenticalEqualityAssertion:
+  Enabled: true
+RSpec/SubjectDeclaration:
+  Enabled: true
+RSpec/VerifiedDoubleReference:
+  Enabled: true
+RSpec/Capybara/SpecificMatcher:
+  Enabled: true
+RSpec/FactoryBot/SyntaxMethods:
+  Enabled: true
+RSpec/Rails/AvoidSetupHook:
+  Enabled: true

spec/rubocop/cop/rspec/scattered_let_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::RSpec::ScatteredLet do
-  it 'flags `let` after the first different node ' do
+  it 'flags `let` after the first different node' do
     expect_offense(<<-RUBY)
       RSpec.describe User do
         let(:a) { a }

spec/rubocop/rspec/example_spec.rb

@@ -39,7 +39,7 @@ def example(source)
   end
 
   it 'returns nil for examples without doc strings' do
-    expect(example('it { foo }').doc_string).to be(nil)
+    expect(example('it { foo }').doc_string).to be_nil
   end
 
   it 'extracts keywords' do
@@ -58,12 +58,14 @@ def example(source)
   end
 
   describe 'value object semantics' do
+    # rubocop:disable RSpec/IdenticalEqualityAssertion
     it 'compares by value' do
       aggregate_failures 'equality semantics' do
         expect(example('it("foo")')).to eq(example('it("foo")'))
         expect(example('it("foo")')).not_to eq(example('it("bar")'))
       end
     end
+    # rubocop:enable RSpec/IdenticalEqualityAssertion
 
     it 'can be used as a key in a hash' do
       hash = {}