Skip to content

Commit 22b778a

Browse files
committed
Fix changelog formatting
And add a spec to check the contributors list in the Changelog.
1 parent e11f6e3 commit 22b778a

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -513,8 +513,8 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
513513
[@rspeicher]: https://github.com/rspeicher
514514
[@jonatas]: https://github.com/jonatas
515515
[@pocke]: https://github.com/pocke
516-
[@bmorrall]: https:/github.com/bmorrall
517-
[@zverok]: https:/github.com/zverok
516+
[@bmorrall]: https://github.com/bmorrall
517+
[@zverok]: https://github.com/zverok
518518
[@timrogers]: https://github.com/timrogers
519519
[@yevhene]: https://github.com/yevhene
520520
[@walf443]: https://github.com/walf443
@@ -559,7 +559,6 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
559559
[@andrykonchin]: https://github.com/andrykonchin
560560
[@harrylewis]: https://github.com/harrylewis
561561
[@elliterate]: https://github.com/elliterate
562-
[@mlarraz]: https://github.com/mlarraz
563562
[@jtannas]: https://github.com/jtannas
564563
[@mockdeep]: https://github.com/mockdeep
565564
[@biinari]: https://github.com/biinari

spec/project/changelog_spec.rb

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,22 @@
1010
end
1111
end
1212

13+
describe 'contributors' do
14+
let(:contributors) do
15+
changelog.partition("<!-- Contributors -->\n\n").last.lines
16+
end
17+
18+
it 'does not contain duplicates' do
19+
expect(contributors.uniq).to eq(contributors)
20+
end
21+
22+
it 'links to github profiles' do
23+
expect(contributors).to all(
24+
match(%r{\A\[@([^\]]+)\]: https://github.com/\1\n\z})
25+
)
26+
end
27+
end
28+
1329
describe 'entry' do
1430
subject(:entries) { lines.grep(/^\*/).map(&:chomp) }
1531

0 commit comments

Comments
 (0)