Fix "better" code in RSpec/MessageChain cop

schwern · web-flow · commit 23ca27c613d0 · 2019-12-12T13:40:44.000-08:00
The original code results in an error, `receive` takes a single argument of the method name. ``` NoMethodError: undefined method `to_sym' for {:bar=>#<Thing:0x00007ff34792c178 @baz=42>}:Hash Did you mean? to_s to_set ```
diff --git a/lib/rubocop/cop/rspec/message_chain.rb b/lib/rubocop/cop/rspec/message_chain.rb
@@ -11,7 +11,7 @@ module RSpec
       #
       #   # better
       #   thing = Thing.new(baz: 42)
-      #   allow(foo).to receive(bar: thing)
+      #   allow(foo).to receive(:bar).and_return(thing)
       #
       class MessageChain < Cop
         MSG = 'Avoid stubbing using `%<method>s`.'

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ module RSpec`
`11`	`11`	`#`
`12`	`12`	`# # better`
`13`	`13`	`# thing = Thing.new(baz: 42)`
`14`		`- # allow(foo).to receive(bar: thing)`
	`14`	`+ # allow(foo).to receive(:bar).and_return(thing)`
`15`	`15`	`#`
`16`	`16`	`class MessageChain < Cop`
`17`	`17`	MSG = 'Avoid stubbing using `%<method>s`.'