Fix message of RSpec/Rails/HaveHttpStatus

Author: akiomik

lib/rubocop/cop/rspec/rails/have_http_status.rb

@@ -16,8 +16,9 @@ module Rails
         class HaveHttpStatus < Base
           extend AutoCorrector
 
-          MSG = 'Prefer `expect(response.status).%<to>s %<match>s` ' \
-                'over `expect(response).%<to>s have_http_status(%<status>i)`.'
+          MSG =
+            'Prefer `expect(response).%<to>s have_http_status(%<status>i)` ' \
+            'over `expect(response.status).%<to>s %<match>s`.'
 
           # @!method match_status(node)
           def_node_matcher :match_status, <<-PATTERN

spec/rubocop/cop/rspec/rails/have_http_status_spec.rb

@@ -4,7 +4,7 @@
   it 'registers an offense for `expect(response.status).to be 200`' do
     expect_offense(<<~RUBY)
       it { expect(response.status).to be 200 }
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `expect(response.status).to be 200` over `expect(response).to have_http_status(200)`.
+           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `expect(response).to have_http_status(200)` over `expect(response.status).to be 200`.
     RUBY
 
     expect_correction(<<~RUBY)
@@ -15,7 +15,7 @@
   it 'registers an offense for `expect(response.status).not_to eq 404`' do
     expect_offense(<<~RUBY)
       it { expect(response.status).not_to eq(404) }
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `expect(response.status).not_to eq(404)` over `expect(response).not_to have_http_status(404)`.
+           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `expect(response).not_to have_http_status(404)` over `expect(response.status).not_to eq(404)`.
     RUBY
 
     expect_correction(<<~RUBY)