RSpec/SubjectStub. Code review fixes.

Author: andrykonchin

lib/rubocop/rspec/top_level_group.rb

@@ -4,13 +4,11 @@ module RuboCop
   module RSpec
     # Helper methods for top level example group cops
     module TopLevelGroup
-      extend NodePattern::Macros
+      extend RuboCop::NodePattern::Macros
+      include RuboCop::RSpec::Language
 
       def_node_matcher :example_or_shared_group?,
-                       (
-                         Language::ExampleGroups::ALL +
-                         Language::SharedGroups::ALL
-                       ).block_pattern
+                       (ExampleGroups::ALL + SharedGroups::ALL).block_pattern
 
       def on_block(node)
         return unless respond_to?(:on_top_level_group)
@@ -26,12 +24,12 @@ def top_level_group?(node)
       end
 
       def top_level_groups
-        @top_level_groups ||= \
+        @top_level_groups ||=
           top_level_nodes.select { |n| example_or_shared_group?(n) }
       end
 
       def top_level_nodes
-        @top_level_nodes ||= \
+        @top_level_nodes ||=
           if root_node.begin_type?
             root_node.children
           else

spec/rubocop/cop/rspec/subject_stub_spec.rb

@@ -324,20 +324,20 @@
 
   it 'flags when there are several top level example groups' do
     expect_offense(<<-RUBY)
-      describe Foo do
+      RSpec.describe Foo do
         subject(:foo) { described_class.new }
 
         specify do
           expect(foo).to eq(foo)
         end
       end
 
-      describe Bar do
+      RSpec.describe Bar do
         subject(:bar) { described_class.new }
 
         specify do
-          allow(bar).to receive(:bar).and_return(baz)
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
+          allow(bar).to receive(:bar)
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
         end
       end
     RUBY
@@ -353,10 +353,10 @@
     ].each do |method|
       it "flags in top level #{method}" do
         expect_offense(<<-RUBY)
-          #{method} '#{method}' do
+          RSpec.#{method} '#{method}' do
             it 'uses an implicit subject' do
-              expect(subject).to receive(:bar).and_return(baz)
-              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
+              expect(subject).to receive(:bar)
+              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
             end
           end
         RUBY