Skip to content

Commit 468a576

Browse files
committed
Change to use common ASCII characters
- Use U+002d instead of U+2013 - Use U+2019 instead of U+0060
1 parent dd44230 commit 468a576

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

docs/modules/ROOT/pages/index.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ https://github.com/rubocop/rubocop[RuboCop].
55

66
RuboCop RSpec follows the https://docs.rubocop.org/rubocop/versioning.html[RuboCop versioning guide].
77
In a nutshell, between major versions new cops are introduced in a special `pending` status.
8-
That means that they wont be run unless explicitly told otherwise.
8+
That means that they won't be run unless explicitly told otherwise.
99
RuboCop will warn on start that certain cops are neither explicitly enabled and disabled.
1010
On a major version release, all `pending` cops are enabled.
1111

@@ -32,7 +32,7 @@ over
3232
calculator.compute(line_item).should == 5
3333
----
3434

35-
is a feature of RSpec itself you can read about it in the https://relishapp.com/rspec/rspec-expectations/docs/syntax-configuration#disable-should-syntax[RSpec Documentation].
35+
is a feature of RSpec itself - you can read about it in the https://relishapp.com/rspec/rspec-expectations/docs/syntax-configuration#disable-should-syntax[RSpec Documentation].
3636

3737
=== Enforcing an explicit RSpec receiver for top-level methods (disabling monkey patching)
3838

docs/modules/ROOT/pages/third_party_rspec_syntax_extensions.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ Please check with the xref:usage.adoc#rspec-dsl-configuration[RSpec DSL configur
2323
inherit_gem:
2424
third-party-gem: .rubocop_rspec_alias_config.yml
2525

26-
3. Include the configuration file to their package by updating their `gemspec`s `spec.files` to include the aforementioned configuration file.
26+
3. Include the configuration file to their package by updating their `gemspec`'s `spec.files` to include the aforementioned configuration file.
2727

2828
See pull requests: https://github.com/test-prof/test-prof/pull/199[test-prof], and https://github.com/palkan/action_policy/pull/138[action_policy] for a less trivial example.

docs/modules/ROOT/pages/upgrade_to_version_2.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ In version 2.x:
77

88
- `RSpec/InvalidPredicateMatcher` cop is removed
99
- `CustomIncludeMethods` configuration option for `RSpec/EmptyExampleGroup` is removed
10-
- cop departments are nested for cops with a department that doesnt match the extension name (`Capybara`, `FactoryBot`, `Rails`)
10+
- cop departments are nested for cops with a department that doesn't match the extension name (`Capybara`, `FactoryBot`, `Rails`)
1111
- `AllCops/RSpec/Patterns`/`AllCops/FactoryBot/Patterns` options are removed
1212
- Calling `super` from `#on_new_investigation` defined in a cop is mandatory now
1313
- In specs, do not define `cop`
@@ -36,8 +36,8 @@ RSpec:
3636

3737
RuboCop extensions had cops with clashing names and departments, e.g. both `rspec-rails` and `rubocop-rspec` had `Rails::HttpStatus` cops.
3838
To avoid issues, e.g. inability to disable just one of the cops, each extension now has its own uber-department.
39-
Expectedly, RuboCop RSpecs uber-department name is `RSpec`.
40-
Changes are only applied to cops that dont already have the department set to `RSpec`, i.e. `Capybara`, `FactoryBot` and `Rails`.
39+
Expectedly, RuboCop RSpec's uber-department name is `RSpec`.
40+
Changes are only applied to cops that don't already have the department set to `RSpec`, i.e. `Capybara`, `FactoryBot` and `Rails`.
4141

4242
[source,yaml]
4343
----
@@ -138,7 +138,7 @@ https://github.com/rubocop/rubocop-rspec/pull/962[Example pull request].
138138
`TopLevelDescribe` was incomplete, had poor performance and did not distinguish between example groups and shared example groups.
139139

140140
`TopLevelGroup` provides a similar interface, but instead of a single `on_top_level_describe` hook there are two, `on_top_level_example_group` and `on_top_level_group`.
141-
Theres no need yet for `on_top_level_shared_group` for RuboCop core cops, but if your custom cop needs such a hook, please feel free to send a pull request.
141+
There's no need yet for `on_top_level_shared_group` for RuboCop core cops, but if your custom cop needs such a hook, please feel free to send a pull request.
142142

143143
Additionally, `single_top_level_describe?` is removed with no direct replacement.
144144
You may use `top_level_groups` query method instead, e.g. `top_level_groups.one?`.
@@ -269,5 +269,5 @@ https://github.com/rubocop/rubocop/blob/51ff1d7e29c985732fe129082c98d66c531a2611
269269
=== Conform with RuboCop API Changes
270270

271271
The parent project, RuboCop, has API changes.
272-
While they wont result in cop breakages, it is recommended to update cops to use new APIs.
273-
Follow the https://docs.rubocop.org/rubocop/v1_upgrade_notes[RuboCop v1 update guide] to adjust custom cops use of RuboCops auto-correction API.
272+
While they won't result in cop breakages, it is recommended to update cops to use new API's.
273+
Follow the https://docs.rubocop.org/rubocop/v1_upgrade_notes[RuboCop v1 update guide] to adjust custom cops' use of RuboCop's auto-correction API.

lib/rubocop/cop/rspec/instance_variable.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ module RSpec
4848
class InstanceVariable < Base
4949
include TopLevelGroup
5050

51-
MSG = 'Avoid instance variables use let, ' \
51+
MSG = 'Avoid instance variables - use let, ' \
5252
'a method call, or a local variable (if possible).'
5353

5454
# @!method dynamic_class?(node)

spec/rubocop/cop/rspec/instance_variable_spec.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
describe MyClass do
77
before { @foo = [] }
88
it { expect(@foo).to be_empty }
9-
^^^^ Avoid instance variables use let, a method call, or a local variable (if possible).
9+
^^^^ Avoid instance variables - use let, a method call, or a local variable (if possible).
1010
end
1111
RUBY
1212
end
@@ -24,7 +24,7 @@
2424
expect_offense(<<-RUBY)
2525
shared_examples 'shared example' do
2626
it { expect(@foo).to be_empty }
27-
^^^^ Avoid instance variables use let, a method call, or a local variable (if possible).
27+
^^^^ Avoid instance variables - use let, a method call, or a local variable (if possible).
2828
end
2929
RUBY
3030
end
@@ -34,9 +34,9 @@
3434
describe MyClass do
3535
before { @foo = [] }
3636
it { expect(@foo).to be_empty }
37-
^^^^ Avoid instance variables use let, a method call, or a local variable (if possible).
37+
^^^^ Avoid instance variables - use let, a method call, or a local variable (if possible).
3838
it { expect(@bar).to be_empty }
39-
^^^^ Avoid instance variables use let, a method call, or a local variable (if possible).
39+
^^^^ Avoid instance variables - use let, a method call, or a local variable (if possible).
4040
end
4141
RUBY
4242
end
@@ -106,7 +106,7 @@ def serialize
106106
end
107107
108108
it { expect(color: 1).to @matcher }
109-
^^^^^^^^ Avoid instance variables use let, a method call, or a local variable (if possible).
109+
^^^^^^^^ Avoid instance variables - use let, a method call, or a local variable (if possible).
110110
end
111111
RUBY
112112
end
@@ -138,7 +138,7 @@ def serialize
138138
describe MyClass do
139139
before { @foo = [] }
140140
it { expect(@foo).to be_empty }
141-
^^^^ Avoid instance variables use let, a method call, or a local variable (if possible).
141+
^^^^ Avoid instance variables - use let, a method call, or a local variable (if possible).
142142
end
143143
RUBY
144144
end
@@ -160,7 +160,7 @@ def serialize
160160
end
161161
162162
it { expect(@foo).to be_empty }
163-
^^^^ Avoid instance variables use let, a method call, or a local variable (if possible).
163+
^^^^ Avoid instance variables - use let, a method call, or a local variable (if possible).
164164
end
165165
RUBY
166166
end

0 commit comments

Comments
 (0)