Merge pull request #1975 from corsonknowles/require_void_expect_acts_inside_an_example_block

Require VoidExpect to operate inside an example block

Author: bquorning

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Master (Unreleased)
 
+- Fix `RSpec/VoidExpect` to only operate inside an example block. ([@corsonknowles])
 - Change `RSpec/ContextWording` cop to always report an offense when both `Prefixes` and `AllowedPatterns` are empty. ([@ydah])
 - Fix an error for `RSpec/ChangeByZero` when `change (...) .by (0)` and `change (...)`, concatenated with `and` and `or`. ([@ydah])
 

lib/rubocop/cop/rspec/void_expect.rb

@@ -29,12 +29,14 @@ class VoidExpect < Base
 
         def on_send(node)
           return unless expect?(node)
+          return unless inside_example?(node)
 
           check_expect(node)
         end
 
         def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
           return unless expect_block?(node)
+          return unless inside_example?(node)
 
           check_expect(node)
         end
@@ -49,11 +51,14 @@ def check_expect(node)
 
         def void?(expect)
           parent = expect.parent
-          return true unless parent
           return true if parent.begin_type?
 
           parent.block_type? && parent.body == expect
         end
+
+        def inside_example?(node)
+          node.each_ancestor(:block).any? { |ancestor| example?(ancestor) }
+        end
       end
     end
   end

spec/rubocop/cop/rspec/void_expect_spec.rb

@@ -44,4 +44,26 @@
       end
     RUBY
   end
+
+  it 'ignores unrelated method named expect in an example block' do
+    expect_no_offenses(<<~RUBY)
+      it 'something' do
+        MyObject.expect(:foo)
+      end
+    RUBY
+  end
+
+  context 'when expect has no parent node' do
+    it 'does not register an offense' do
+      expect_no_offenses(<<~RUBY)
+        expect(something)
+      RUBY
+    end
+
+    it 'does not register an offense for unrelated expect with block' do
+      expect_no_offenses(<<~RUBY)
+        expect { block_contents }
+      RUBY
+    end
+  end
 end