Merge pull request #1285 from tejasbubane/fix-1284

Fix error in `RSpec/RSpec/FactoryBot/CreateList` cop for empty block

Author: pirj

CHANGELOG.md

@@ -6,6 +6,7 @@
 * Fix autocorrect for EmptyLineSeparation. ([@johnny-miyake][])
 * Add new `RSpec/Capybara/SpecificMatcher` cop. ([@ydah][])
 * Fixed false offense detection in `FactoryBot/CreateList` when a n.times block is including method calls in the factory create arguments. ([@ngouy][])
+* Fix error in `RSpec/RSpec/FactoryBot/CreateList` cop for empty block. ([@tejasbubane][])
 
 ## 2.11.1 (2022-05-18)
 

lib/rubocop/cop/rspec/factory_bot/create_list.rb

@@ -76,6 +76,7 @@ def on_block(node)
 
             return unless n_times_block?(node)
             return if n_times_block_with_arg_and_used?(node)
+            return unless node.body
             return if arguments_include_method_call?(node.body)
             return unless contains_only_factory?(node.body)
 

spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb

@@ -82,6 +82,12 @@
       RUBY
     end
 
+    it 'ignores empty n.times' do
+      expect_no_offenses(<<~RUBY)
+        3.times {}
+      RUBY
+    end
+
     it 'ignores n.times when there is other calls but create' do
       expect_no_offenses(<<~RUBY)
         used_passwords = []