Skip to content

Commit 58dd803

Browse files
authored
Merge pull request #1308 from Drowze/verified-double-reference-unsafe
Mark RSpec/VerifiedDoubleReference as unsafe
2 parents 5928b3d + aa00d32 commit 58dd803

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
* Fixed false offense detection in `FactoryBot/CreateList` when a n.times block is including method calls in the factory create arguments. ([@ngouy][])
99
* Fix error in `RSpec/RSpec/FactoryBot/CreateList` cop for empty block. ([@tejasbubane][])
1010
* Update `RSpec/MultipleExpectations` cop documentation with examples of aggregate_failures use. ([@edgibbs][])
11+
* Declare autocorrect as unsafe for `RSpec/VerifiedDoubleReference`. ([@Drowze][])
1112

1213
## 2.11.1 (2022-05-18)
1314

@@ -704,3 +705,4 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
704705
[@johnny-miyake]: https://github.com/johnny-miyake
705706
[@ngouy]: https://github.com/ngouy
706707
[@edgibbs]: https://github.com/edgibbs
708+
[@Drowze]: https://github.com/Drowze

config/default.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -783,11 +783,13 @@ RSpec/VariableName:
783783
RSpec/VerifiedDoubleReference:
784784
Description: Checks for consistent verified double reference style.
785785
Enabled: pending
786+
SafeAutoCorrect: false
786787
EnforcedStyle: constant
787788
SupportedStyles:
788789
- constant
789790
- string
790791
VersionAdded: 2.10.0
792+
VersionChanged: '2.12'
791793
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubleReference
792794

793795
RSpec/VerifiedDoubles:

docs/modules/ROOT/pages/cops_rspec.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4429,9 +4429,9 @@ let(:userFood_2) { 'fettuccine' }
44294429

44304430
| Pending
44314431
| Yes
4432-
| Yes
4432+
| Yes (Unsafe)
44334433
| 2.10.0
4434-
| -
4434+
| 2.12
44354435
|===
44364436

44374437
Checks for consistent verified double reference style.

0 commit comments

Comments
 (0)