Merge pull request #1627 from rubocop/fix-indexed-let-false-positive-for-suffixes

Fix a false positive with suffixes after index-like numbers in RSpec/IndexedLet

Author: pirj

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+- Fix a false positive in `RSpec/IndexedLet` with suffixes after index-like numbers. ([@pirj])
+
 ## 2.20.0 (2023-04-18)
 
 - Add new `RSpec/IndexedLet` cop. ([@dmitrytsepelev])

lib/rubocop/cop/rspec/indexed_let.rb

@@ -56,19 +56,24 @@ def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
 
         private
 
-        INDEX_REGEX = /_?\d+/.freeze
+        SUFFIX_INDEX_REGEX = /_?\d+$/.freeze
+        INDEX_REGEX = /\d+/.freeze
 
         def filter_indexed_lets(candidates)
           candidates
             .filter { |node| indexed_let?(node) }
-            .group_by { |node| let_name(node).to_s.gsub(INDEX_REGEX, '') }
+            .group_by { |node| let_name_stripped_index(node) }
             .values
             .filter { |lets| lets.length > cop_config['Max'] }
             .flatten
         end
 
         def indexed_let?(node)
-          let?(node) && INDEX_REGEX.match?(let_name(node))
+          let?(node) && SUFFIX_INDEX_REGEX.match?(let_name(node))
+        end
+
+        def let_name_stripped_index(node)
+          let_name(node).to_s.gsub(INDEX_REGEX, '')
         end
       end
     end

spec/rubocop/cop/rspec/indexed_let_spec.rb

@@ -73,6 +73,15 @@
     RUBY
   end
 
+  it 'ignores names with an index-like and a suffix' do
+    expect_no_offenses(<<~RUBY)
+      context SomeService do
+        let(:user_7_day_average) { 700 }
+        let(:user_30_day_average) { 3000 }
+      end
+    RUBY
+  end
+
   it 'not flags which have different prefixes' do
     expect_no_offenses(<<~RUBY)
       describe SomeService do