Skip to content

Commit 5d87427

Browse files
authored
Merge pull request #1902 from rubocop/enable-pending-cops
Enable all pending cops
2 parents f3064a2 + 1af0b78 commit 5d87427

File tree

3 files changed

+65
-64
lines changed

3 files changed

+65
-64
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
- Add new `RSpec/ExpectInLet` cop. ([@yasu551])
99
- Remove `RSpec/Capybara/FeatureMethods` cop. If you are using this cop, change it to use `RSpec/Dialect`. ([@ydah])
1010
- Support `AutoCorrect: contextual` option for LSP. ([@ydah])
11+
- Enable all pending cops. ([@bquorning])
1112

1213
## 2.29.2 (2024-05-02)
1314

config/default.yml

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -146,15 +146,15 @@ RSpec/Be:
146146

147147
RSpec/BeEmpty:
148148
Description: Prefer using `be_empty` when checking for an empty array.
149-
Enabled: pending
149+
Enabled: true
150150
AutoCorrect: contextual
151151
VersionAdded: '2.20'
152152
VersionChanged: "<<next>>"
153153
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEmpty
154154

155155
RSpec/BeEq:
156156
Description: Check for expectations where `be(...)` can replace `eq(...)`.
157-
Enabled: pending
157+
Enabled: true
158158
Safe: false
159159
VersionAdded: 2.9.0
160160
VersionChanged: '2.16'
@@ -170,7 +170,7 @@ RSpec/BeEql:
170170

171171
RSpec/BeNil:
172172
Description: Ensures a consistent style is used when matching `nil`.
173-
Enabled: pending
173+
Enabled: true
174174
EnforcedStyle: be_nil
175175
SupportedStyles:
176176
- be
@@ -193,7 +193,7 @@ RSpec/BeforeAfterAll:
193193

194194
RSpec/ChangeByZero:
195195
Description: Prefer negated matchers over `to change.by(0)`.
196-
Enabled: pending
196+
Enabled: true
197197
VersionAdded: '2.11'
198198
VersionChanged: '2.14'
199199
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ChangeByZero
@@ -202,7 +202,7 @@ RSpec/ChangeByZero:
202202
RSpec/ClassCheck:
203203
Description: Enforces consistent use of `be_a` or `be_kind_of`.
204204
StyleGuide: "#is-a-vs-kind-of"
205-
Enabled: pending
205+
Enabled: true
206206
VersionAdded: '2.13'
207207
EnforcedStyle: be_a
208208
SupportedStyles:
@@ -212,7 +212,7 @@ RSpec/ClassCheck:
212212

213213
RSpec/ContainExactly:
214214
Description: Checks where `contain_exactly` is used.
215-
Enabled: pending
215+
Enabled: true
216216
VersionAdded: '2.19'
217217
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ContainExactly
218218

@@ -306,7 +306,7 @@ RSpec/Dialect:
306306

307307
RSpec/DuplicatedMetadata:
308308
Description: Avoid duplicated metadata.
309-
Enabled: pending
309+
Enabled: true
310310
VersionAdded: '2.16'
311311
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DuplicatedMetadata
312312

@@ -367,21 +367,21 @@ RSpec/EmptyLineAfterSubject:
367367

368368
RSpec/EmptyMetadata:
369369
Description: Avoid empty metadata hash.
370-
Enabled: pending
370+
Enabled: true
371371
AutoCorrect: contextual
372372
VersionAdded: '2.24'
373373
VersionChanged: "<<next>>"
374374
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyMetadata
375375

376376
RSpec/EmptyOutput:
377377
Description: Check that the `output` matcher is not called with an empty string.
378-
Enabled: pending
378+
Enabled: true
379379
VersionAdded: '2.29'
380380
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyOutput
381381

382382
RSpec/Eq:
383383
Description: Use `eq` instead of `be ==` to compare objects.
384-
Enabled: pending
384+
Enabled: true
385385
VersionAdded: '2.24'
386386
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Eq
387387

@@ -423,7 +423,7 @@ RSpec/ExampleWording:
423423

424424
RSpec/ExcessiveDocstringSpacing:
425425
Description: Checks for excessive whitespace in example descriptions.
426-
Enabled: pending
426+
Enabled: true
427427
VersionAdded: '2.5'
428428
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing
429429

@@ -456,8 +456,8 @@ RSpec/ExpectInHook:
456456

457457
RSpec/ExpectInLet:
458458
Description: Do not use `expect` in let.
459-
Enabled: pending
460-
VersionAdded: "<<next>>"
459+
Enabled: true
460+
VersionAdded: '2.30'
461461
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectInLet
462462

463463
RSpec/ExpectOutput:
@@ -496,7 +496,7 @@ RSpec/HooksBeforeExamples:
496496

497497
RSpec/IdenticalEqualityAssertion:
498498
Description: Checks for equality assertions with identical expressions on both sides.
499-
Enabled: pending
499+
Enabled: true
500500
VersionAdded: '2.4'
501501
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IdenticalEqualityAssertion
502502

@@ -533,7 +533,7 @@ RSpec/ImplicitSubject:
533533

534534
RSpec/IndexedLet:
535535
Description: Do not set up test data using indexes (e.g., `item_1`, `item_2`).
536-
Enabled: pending
536+
Enabled: true
537537
VersionAdded: '2.20'
538538
VersionChanged: '2.23'
539539
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IndexedLet
@@ -558,7 +558,7 @@ RSpec/InstanceVariable:
558558

559559
RSpec/IsExpectedSpecify:
560560
Description: Check for `specify` with `is_expected` and one-liner expectations.
561-
Enabled: pending
561+
Enabled: true
562562
VersionAdded: '2.27'
563563
StyleGuide: https://rspec.rubystyle.guide/#it-and-specify
564564
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IsExpectedSpecify
@@ -610,7 +610,7 @@ RSpec/LetSetup:
610610

611611
RSpec/MatchArray:
612612
Description: Checks where `match_array` is used.
613-
Enabled: pending
613+
Enabled: true
614614
VersionAdded: '2.19'
615615
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MatchArray
616616

@@ -643,7 +643,7 @@ RSpec/MessageSpies:
643643

644644
RSpec/MetadataStyle:
645645
Description: Use consistent metadata style.
646-
Enabled: pending
646+
Enabled: true
647647
EnforcedStyle: symbol
648648
SupportedStyles:
649649
- hash
@@ -711,7 +711,7 @@ RSpec/NestedGroups:
711711

712712
RSpec/NoExpectationExample:
713713
Description: Checks if an example contains any expectation.
714-
Enabled: pending
714+
Enabled: true
715715
Safe: false
716716
VersionAdded: '2.13'
717717
VersionChanged: '2.14'
@@ -744,7 +744,7 @@ RSpec/Pending:
744744

745745
RSpec/PendingWithoutReason:
746746
Description: Checks for pending or skipped examples without reason.
747-
Enabled: pending
747+
Enabled: true
748748
VersionAdded: '2.16'
749749
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PendingWithoutReason
750750

@@ -770,7 +770,7 @@ RSpec/ReceiveCounts:
770770

771771
RSpec/ReceiveMessages:
772772
Description: Checks for multiple messages stubbed on the same object.
773-
Enabled: pending
773+
Enabled: true
774774
SafeAutoCorrect: false
775775
VersionAdded: '2.23'
776776
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReceiveMessages
@@ -783,19 +783,19 @@ RSpec/ReceiveNever:
783783

784784
RSpec/RedundantAround:
785785
Description: Remove redundant `around` hook.
786-
Enabled: pending
786+
Enabled: true
787787
VersionAdded: '2.19'
788788
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RedundantAround
789789

790790
RSpec/RedundantPredicateMatcher:
791791
Description: Checks for redundant predicate matcher.
792-
Enabled: pending
792+
Enabled: true
793793
VersionAdded: '2.26'
794794
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RedundantPredicateMatcher
795795

796796
RSpec/RemoveConst:
797797
Description: Checks that `remove_const` is not used in specs.
798-
Enabled: pending
798+
Enabled: true
799799
VersionAdded: '2.26'
800800
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RemoveConst
801801

@@ -831,7 +831,7 @@ RSpec/RepeatedIncludeExample:
831831

832832
RSpec/RepeatedSubjectCall:
833833
Description: Checks for repeated calls to subject missing that it is memoized.
834-
Enabled: pending
834+
Enabled: true
835835
VersionAdded: '2.27'
836836
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedSubjectCall
837837

@@ -888,19 +888,19 @@ RSpec/SingleArgumentMessageChain:
888888

889889
RSpec/SkipBlockInsideExample:
890890
Description: Checks for passing a block to `skip` within examples.
891-
Enabled: pending
891+
Enabled: true
892892
VersionAdded: '2.19'
893893
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SkipBlockInsideExample
894894

895895
RSpec/SortMetadata:
896896
Description: Sort RSpec metadata alphabetically.
897-
Enabled: pending
897+
Enabled: true
898898
VersionAdded: '2.14'
899899
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SortMetadata
900900

901901
RSpec/SpecFilePathFormat:
902902
Description: Checks that spec file paths are consistent and well-formed.
903-
Enabled: pending
903+
Enabled: true
904904
Include:
905905
- "**/*_spec.rb"
906906
Exclude:
@@ -916,7 +916,7 @@ RSpec/SpecFilePathFormat:
916916

917917
RSpec/SpecFilePathSuffix:
918918
Description: Checks that spec file paths suffix are consistent and well-formed.
919-
Enabled: pending
919+
Enabled: true
920920
VersionAdded: '2.24'
921921
Include:
922922
- "**/*_spec*rb*"
@@ -931,7 +931,7 @@ RSpec/StubbedMock:
931931

932932
RSpec/SubjectDeclaration:
933933
Description: Ensure that subject is defined using subject helper.
934-
Enabled: pending
934+
Enabled: true
935935
VersionAdded: '2.5'
936936
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SubjectDeclaration
937937

@@ -945,7 +945,7 @@ RSpec/SubjectStub:
945945

946946
RSpec/UndescriptiveLiteralsDescription:
947947
Description: Description should be descriptive.
948-
Enabled: pending
948+
Enabled: true
949949
VersionAdded: '2.29'
950950
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/UndescriptiveLiteralsDescription
951951

@@ -979,7 +979,7 @@ RSpec/VariableName:
979979

980980
RSpec/VerifiedDoubleReference:
981981
Description: Checks for consistent verified double reference style.
982-
Enabled: pending
982+
Enabled: true
983983
SafeAutoCorrect: false
984984
EnforcedStyle: constant
985985
SupportedStyles:

0 commit comments

Comments
 (0)