Update docs

Author: ydakuka

docs/modules/ROOT/pages/cops.adoc

@@ -22,8 +22,8 @@
 * xref:cops_rspec.adoc#rspecdescribesymbol[RSpec/DescribeSymbol]
 * xref:cops_rspec.adoc#rspecdescribedclass[RSpec/DescribedClass]
 * xref:cops_rspec.adoc#rspecdescribedclassmodulewrapping[RSpec/DescribedClassModuleWrapping]
-* xref:cops_rspec.adoc#rspecdiscardedmatcher[RSpec/DiscardedMatcher]
 * xref:cops_rspec.adoc#rspecdialect[RSpec/Dialect]
+* xref:cops_rspec.adoc#rspecdiscardedmatcher[RSpec/DiscardedMatcher]
 * xref:cops_rspec.adoc#rspecduplicatedmetadata[RSpec/DuplicatedMetadata]
 * xref:cops_rspec.adoc#rspecemptyexamplegroup[RSpec/EmptyExampleGroup]
 * xref:cops_rspec.adoc#rspecemptyhook[RSpec/EmptyHook]

docs/modules/ROOT/pages/cops_rspec.adoc

@@ -1129,55 +1129,6 @@ end
 * https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClassModuleWrapping
 * https://github.com/rubocop/rubocop-rspec/issues/735
 
-[#rspecdiscardedmatcher]
-== RSpec/DiscardedMatcher
-
-|===
-| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
-
-| Enabled
-| Yes
-| No
-| <<next_version>>
-| -
-|===
-
-Checks for matchers that are used in void context.
-
-Matcher calls like `change`, `receive`, etc. that appear as standalone
-expressions have their result silently discarded. This usually means a
-missing `.and` to chain compound matchers.
-
-[#examples-rspecdiscardedmatcher]
-=== Examples
-
-[source,ruby]
-----
-# bad
-specify do
-  expect { result }.to \
-    change { obj.foo }.from(1).to(2)
-    change { obj.bar }.from(3).to(4)
-end
-
-# good
-specify do
-  expect { result }.to \
-    change { obj.foo }.from(1).to(2)
-    .and change { obj.bar }.from(3).to(4)
-end
-
-# good
-specify do
-  expect { result }.to change { obj.foo }.from(1).to(2)
-end
-----
-
-[#references-rspecdiscardedmatcher]
-=== References
-
-* https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DiscardedMatcher
-
 [#rspecdialect]
 == RSpec/Dialect
 
@@ -1265,6 +1216,69 @@ end
 
 * https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Dialect
 
+[#rspecdiscardedmatcher]
+== RSpec/DiscardedMatcher
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| Yes
+| No
+| <<next>>
+| -
+|===
+
+Checks for matchers that are used in void context.
+
+Matcher calls like `change`, `receive`, etc. that appear as
+standalone expressions have their result silently discarded.
+This usually means a missing `.and` to chain compound matchers.
+
+The list of matcher methods can be configured
+with `CustomMatcherMethods`.
+
+[#examples-rspecdiscardedmatcher]
+=== Examples
+
+[source,ruby]
+----
+# bad
+specify do
+  expect { result }
+    .to change { obj.foo }.from(1).to(2)
+    change { obj.bar }.from(3).to(4)
+end
+
+# good
+specify do
+  expect { result }
+    .to change { obj.foo }.from(1).to(2)
+    .and change { obj.bar }.from(3).to(4)
+end
+
+# good
+specify do
+  expect { result }.to change { obj.foo }.from(1).to(2)
+end
+----
+
+[#configurable-attributes-rspecdiscardedmatcher]
+=== Configurable attributes
+
+|===
+| Name | Default value | Configurable values
+
+| CustomMatcherMethods
+| `[]`
+| Array
+|===
+
+[#references-rspecdiscardedmatcher]
+=== References
+
+* https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DiscardedMatcher
+
 [#rspecduplicatedmetadata]
 == RSpec/DuplicatedMetadata
 

lib/rubocop/cop/rspec/discarded_matcher.rb

@@ -47,7 +47,7 @@ def on_send(node)
           check_discarded_matcher(node, node)
         end
 
-        def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
+        def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler, InternalAffairs/ItblockHandler
           check_discarded_matcher(node.send_node, node)
         end
 

spec/rubocop/cop/rspec/discarded_matcher_spec.rb

@@ -158,18 +158,18 @@
     RUBY
   end
 
-  it 'does not register for `change` in modifier `if` without expect' do
+  it 'does not register for `change` in modifier `if`' do
     expect_no_offenses(<<~RUBY)
       specify do
-        change { obj.bar } if condition
+        expect { result }.to change { obj.bar } if condition
       end
     RUBY
   end
 
-  it 'does not register for `change` in modifier `unless` without expect' do
+  it 'does not register for `change` in modifier `unless`' do
     expect_no_offenses(<<~RUBY)
       specify do
-        change { obj.bar } unless condition
+        expect { result }.to change { obj.bar } unless condition
       end
     RUBY
   end