Merge pull request #881 from rubocop-hq/fix-dstr-in-example-description

Extra specs for RepeatedDescription and Example

Author: bquorning

spec/rubocop/cop/rspec/repeated_description_spec.rb

@@ -146,6 +146,40 @@
     RUBY
   end
 
+  it 'registers offense for repeated description in different iterators' do
+    expect_offense(<<-RUBY)
+      describe 'doing x' do
+        %i[foo bar].each do |type|
+          it "does a thing \#{type}" do
+          ^^^^^^^^^^^^^^^^^^^^^^^^^ Don't repeat descriptions within an example group.
+          end
+        end
+
+        %i[baz qux].each do |type|
+          it "does a thing \#{type}" do
+          ^^^^^^^^^^^^^^^^^^^^^^^^^ Don't repeat descriptions within an example group.
+          end
+        end
+      end
+    RUBY
+  end
+
+  it 'does not flag different descriptions in different iterators' do
+    expect_no_offenses(<<-RUBY)
+      describe 'doing x' do
+        %i[foo bar].each do |type|
+          it "does a thing \#{type}" do
+          end
+        end
+
+        %i[baz qux].each do |type|
+          it "does another thing \#{type}" do
+          end
+        end
+      end
+    RUBY
+  end
+
   it 'registers offense if same method used in docstring' do
     expect_offense(<<-RUBY)
       describe 'doing x' do
@@ -161,4 +195,18 @@
       end
     RUBY
   end
+
+  it 'does not flag different methods used as docstring' do
+    expect_no_offenses(<<-RUBY)
+      describe 'doing x' do
+        it(description) do
+          # ...
+        end
+
+        it(title) do
+          # ...
+        end
+      end
+    RUBY
+  end
 end

spec/rubocop/rspec/example_spec.rb

@@ -22,6 +22,11 @@ def example(source)
       .to eq(s(:dstr, s(:str, 'does '), s(:begin, s(:send, nil, :x))))
   end
 
+  it 'extracts symbol doc string' do
+    expect(example('it(:works_fine)').doc_string)
+      .to eq(s(:sym, :works_fine))
+  end
+
   it 'extracts method doc string' do
     expect(example('it(description)').doc_string)
       .to eq(s(:send, nil, :description))