Make RSpec Hooks fully configurable

Author: sl4vr

config/default.yml

@@ -4,6 +4,15 @@ AllCops:
     Patterns:
     - _spec.rb
     - "(?:^|/)spec/"
+    Language:
+      Hooks:
+      - prepend_before
+      - before
+      - append_before
+      - around
+      - prepend_after
+      - after
+      - append_after
   RSpec/FactoryBot:
     Patterns:
     - spec/factories.rb

lib/rubocop/rspec/language.rb

@@ -67,25 +67,6 @@ def node_pattern
         attr_reader :selectors
       end
 
-      # Built in RSpec selectors
-      module BuiltIn
-        LANGUAGE = {
-          'Hooks' => %i[
-            prepend_before
-            before
-            append_before
-            around
-            prepend_after
-            after
-            append_after
-          ]
-        }.freeze
-
-        def self.language_elements_for(*keys)
-          LANGUAGE.dig(*keys) || []
-        end
-      end
-
       module ExampleGroups
         GROUPS  = SelectorSet.new(%i[describe context feature example_group])
         SKIPPED = SelectorSet.new(%i[xdescribe xcontext xfeature])

lib/rubocop/rspec/language/node_pattern.rb

@@ -43,32 +43,26 @@ def rspec_all(keyword)
 
         # TODO: Fully replace selectors with sets
         def hooks_set
-          @hooks_set ||= Set.new(hook_selectors.send(:selectors))
+          @hooks_set ||= Set.new(rspec_language_config('Hooks'))
         end
 
         def all_set
           @all_set ||= Set.new(all_selectors.send(:selectors))
         end
 
-        def hook_selectors
-          selectors('Hooks')
-        end
-
         def all_selectors
-          ExampleGroups::ALL  +
-            SharedGroups::ALL +
-            Examples::ALL     +
-            hook_selectors    +
-            Helpers::ALL      +
-            Subject::ALL      +
-            Expectations::ALL +
+          ExampleGroups::ALL   +
+            SharedGroups::ALL  +
+            Examples::ALL      +
+            selectors('Hooks') +
+            Helpers::ALL       +
+            Subject::ALL       +
+            Expectations::ALL  +
             Runners::ALL
         end
 
         def selectors(*keys)
-          SelectorSet.new(
-            BuiltIn.language_elements_for(*keys) + rspec_language_config(*keys)
-          )
+          SelectorSet.new(rspec_language_config(*keys))
         end
       end
     end

spec/rubocop/cop/rspec/align_left_let_brace_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::RSpec::AlignLeftLetBrace do
-  subject(:cop) { described_class.new }
-
   # rubocop:disable RSpec/ExampleLength
   it 'registers offense for unaligned braces' do
     expect_offense(<<-RUBY)

spec/rubocop/cop/rspec/align_right_let_brace_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::RSpec::AlignRightLetBrace do
-  subject(:cop) { described_class.new }
-
   # rubocop:disable RSpec/ExampleLength
   it 'registers offense for unaligned braces' do
     expect_offense(<<-RUBY)

spec/rubocop/cop/rspec/any_instance_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::RSpec::AnyInstance do
-  subject(:cop) { described_class.new }
-
   it 'finds `allow_any_instance_of` instead of an instance double' do
     expect_offense(<<-RUBY)
       before do

spec/rubocop/cop/rspec/around_block_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::RSpec::AroundBlock do
-  subject(:cop) { described_class.new }
-
   context 'when no value is yielded' do
     it 'registers an offense' do
       expect_offense(<<-RUBY)

spec/rubocop/cop/rspec/be_eql_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::RSpec::BeEql do
-  subject(:cop) { described_class.new }
-
   it 'registers an offense for `eql` when argument is a boolean' do
     expect_offense(<<-RUBY)
       it { expect(foo).to eql(true) }

spec/rubocop/cop/rspec/be_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::RSpec::Be do
-  subject(:cop) { described_class.new }
-
   it 'registers an offense for `be` without an argument' do
     expect_offense(<<-RUBY)
       it { expect(foo).to be }

spec/rubocop/cop/rspec/before_after_all_spec.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::RSpec::BeforeAfterAll do
-  subject(:cop) { described_class.new }
-
   def message(hook)
     "Beware of using `#{hook}` as it may cause state to leak between tests. "\
     'If you are using `rspec-rails`, and `use_transactional_fixtures` is '\